search

panoptes / panoptes-utils

A set of Astronomical utility functions. PANOPTES style. :hammer_and_wrench: :telescope: :stars:
https://panoptes-utils.readthedocs.io
MIT License
4 stars 9 forks source link

Serial handlers cleanup #301

Closed wtgee closed 2 years ago

wtgee commented 2 years ago

Removing custom serial handlers that are adding lots of code and testing and aren't really providing any benefit.

Changes deprecated rs232.SerialData to use connect in __init__ rather than the underlying self.ser.open.

Closes #276

codecov[bot] commented 2 years ago

Codecov Report

Merging #301 (b4e24a5) into develop (2e02a47) will increase coverage by 1.29%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #301      +/-   ##
===========================================
+ Coverage    90.18%   91.48%   +1.29%     
===========================================
  Files           26       22       -4     
  Lines         1528     1432      -96     
===========================================
- Hits          1378     1310      -68     
+ Misses         150      122      -28
Impacted Files Coverage Δ
src/panoptes/utils/rs232.py 99.02% <100.00%> (+10.23%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.