search

panoptix-za / web-bundler

Bundles a Rust WebAssembly frontend application for publishing
Apache License 2.0
11 stars 3 forks source link

Simplify cargo-rerun-if-changed #8

Closed edmellum closed 11 months ago

edmellum commented 3 years ago

With proper rerun-if-changed directory handling landed in 1.50.0 we can remove the directory handling and walkdir dependency

JWorthe commented 3 years ago

I worry that if we merge this in and someone uses web-bundler from an old version of Cargo it will silently do the wrong thing. I think this should at least check the Cargo version somehow and bail out if it's an old Cargo rather than fail silently. It might also make sense to wait until it's been in stable for a long time, since it forces people to update their toolchain and that might be a problem in environments that move slowly.

As an aside, you should probably also be aware that we're merging web-bundler with another similar project that also manages building wasm. Take a look as https://github.com/wasmbl/wasmbl