search

panoratech / Panora

One API to connect your data sources to your LLMs
https://docs.panora.dev
Apache License 2.0
856 stars 179 forks source link

Add success Dialog and UI improvment #465

Closed mit-27 closed 3 months ago

mit-27 commented 4 months ago

Tasks

Summary

Screenshot 2024-05-27 at 5 46 20 PM
changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 34531fc41b3fce6bf1812b95d63b5eb36b2890d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

@mit-27 is attempting to deploy a commit to the Panora Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 4 months ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates span multiple components and applications, focusing on enhancing UI/UX and functionality. Key changes include layout adjustments in login pages, theme management improvements, new logout and profile functionalities, and OAuth flow enhancements with success notifications.

Changes

File(s) Change Summary
apps/client-ts/src/app/b2c/login/page.tsx Adjusted layout and styling of div elements and Tabs component.
apps/client-ts/src/app/layout.tsx Changed defaultTheme in ThemeProvider from "light" to "system".
apps/client-ts/src/components/Nav/main-nav-sm.tsx Added imports, initializations, and onLogout function for enhanced user navigation and logout functionality.
apps/client-ts/src/components/Nav/main-nav.tsx Adjusted padding in navItemClassName and renamed "Documentation" to "Docs".
apps/client-ts/src/components/Nav/user-nav.tsx Added dropdown menu items for theme selection and adjusted profile display and logout functionality.
apps/client-ts/src/components/RootLayout/index.tsx Added imports and state management for copying project ID with a tooltip and success toast.
apps/client-ts/src/components/shared/team-switcher.tsx Changed PopoverContent class's ml property from ml-20 to ml-4.
apps/client-ts/src/components/Configuration/LinkedUsers/columns.tsx Introduced LinkedUserIdComponent for copying linked user ID with tooltip and success toast.
apps/embedded-catalog/react/src/components/Modal.tsx Introduced Modal component for managing modal dialogs with open and close functionality.
apps/embedded-catalog/react/src/components/PanoraDynamicCatalog.tsx Added imports and state variables, modified useOAuth function, and added modal for OAuth success notification.
apps/magic-link/src/App.tsx Added classes "flex items-center justify-center" to <div> element for styling.
apps/magic-link/src/components/Modal.tsx Introduced Modal component for managing modal dialogs with visibility and content state management.
apps/magic-link/src/hooks/useOAuth.ts Added optional optionalApiUrl parameter, updated useOAuth function, and improved authentication window management.
apps/magic-link/src/lib/ProviderModal.tsx Added imports, state variables, modified useOAuth function, and added modal for OAuth success notification.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant App
    participant OAuthService
    participant UI

    User->>App: Initiates OAuth Flow
    App->>OAuthService: Redirect to OAuth Provider
    OAuthService-->>User: OAuth Authentication
    User-->>OAuthService: Grant Access
    OAuthService-->>App: OAuth Token
    App->>UI: Display Success Notification
    UI-->>User: OAuth Success Message

Assessment against linked issues

Objective (Issue #225) Addressed Explanation
Handle OAuth success status ✅
Prevent re-authentication if OAuth access exists ❌ No specific changes identified addressing re-authentication prevention.
Link unified data to id_connection instead of linkedUser ❓ Unclear if this objective is addressed; no direct changes observed.

Poem

In the realm of code so bright, Changes made both day and night, Themes that shift from light to dark, OAuth flows now hit the mark. With tooltips, modals, and success toast, To these updates, we raise a toast! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rflihxyz commented 4 months ago

@greptileai

gitguardian[bot] commented 4 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9763120](https://dashboard.gitguardian.com/workspace/489351/incidents/9763120) | Triggered | Generic High Entropy Secret | 0130c73f9217a1832b2a35f6fc31c0de38b0dc71 | docs/mint.json | [View secret](https://github.com/panoratech/Panora/commit/0130c73f9217a1832b2a35f6fc31c0de38b0dc71#diff-c91a604899dfef4b2494c317f4fd39a7f22b79986095f580399347293d534debR10) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.