search

panoratech / Panora

One API to connect your data sources to your LLMs
https://docs.panora.dev
Apache License 2.0
945 stars 193 forks source link

Consider drive root to be a folder when syncing onedrive/sharepoint #703

Closed amuwal closed 2 months ago

amuwal commented 2 months ago

Summary by CodeRabbit

naelob commented 2 months ago

Qovery Preview

Qovery can create a Preview Environment for this PR. To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery []() preview 783d0240-ec38-4387-a9a9-8e225f1bd3e1 dev
/qovery []() preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI :robot:. Below, a word from its wisdom :

There are two hard problems in computer science: naming things, cache invalidation and off-by-1 errors

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 7ae8489f200f0d2d1bb126513e0db5ed8cd391a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The changes involve enhancements to the `OnedriveService` and `SharepointService` classes, specifically adding functionality to retrieve root folder data from OneDrive and SharePoint, respectively. Both services now make asynchronous HTTP GET requests to their respective APIs to obtain root folder information, which is then integrated into their result arrays. Additionally, both services introduce a new optional `root` property in their folder input interfaces to indicate whether a `driveItem` is the top-most item in the folder hierarchy. ## Changes | File Path | Change Summary | |----------------------------------------------------------|-------------------------------------------------------------------------------------------------| | `packages/api/src/filestorage/folder/services/onedrive/index.ts` | Enhanced `OnedriveService` to retrieve root folder data from OneDrive and include it in the result array. | | `packages/api/src/filestorage/folder/services/onedrive/types.ts` | Added optional `readonly root?` property to `OnedriveFolderInput` interface. | | `packages/api/src/filestorage/folder/services/sharepoint/index.ts` | Enhanced `SharepointService` to retrieve root folder data from SharePoint and include it in the result array. | | `packages/api/src/filestorage/folder/services/sharepoint/types.ts` | Added optional `readonly root?` property to `SharepointFolderInput` interface. | ## Possibly related PRs - #693: The changes in the `SharepointService` class to retrieve the root folder data from SharePoint are closely related to the enhancements made in the `OnedriveService` class for retrieving root folder data from OneDrive, indicating a parallel development in handling folder structures for both services.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.