Use pip instead of conda as the python package manager, this makes setup easier and fix uvicorn logging problems

panosc-eu / panosc-search-scoring

3 stars 3 forks source link

Use pip instead of conda as the python package manager, this makes setup easier and fix uvicorn logging problems #14

Closed AleCeric closed 2 years ago

AleCeric commented 2 years ago

This solves the issue #8 All tests passed

nitrosx commented 2 years ago

Alessandro this is great!!

Couple of question:

What should I do if I want to test and debug while running locally and I need to use a virtual environment (venv or conda)? Do you think we can provide documentation or a script for that?
you removed the conda environment specific for running notebooks and not be used in production. Do you think we can add it back in? Using just pip and venv would be fine

AleCeric commented 2 years ago

1) Yes, I used venv, I can write a script to prepare a virtual environment ready to be used (i.e. with all requirements installed) plus a line of documentation in order to activate it and launch the scoring-api 2) Yes, I can restore conda environment files

So I'd propose to do another PR with these changes

nitrosx commented 2 years ago

Check this post:

https://newbedev.com/from-conda-create-requirements-txt-for-pip3