Bump version

[stevelacey]

Looks like there's been a fair few commits since 0.4.0, bump the version? Appears the updatecurrencies command in 0.4.0 doesn't work on Django 1.10.

[einarf]

Yes. A new version is definitely needed. I've been installing from a fork here on github for a long time to freeze the master branch.

[racitup]

Is there anything stopping a new version?

[panosl]

@racitup you seem to be doing a good job on keeping things up to date. Reach out to me, if you'd be willing to handle the next release.

[racitup]

Hey, thanks! Unfortunately it seems my yahoo 'integration' (read: scrape) has broken because yahoo changed their site. I'll need to fix this really.

Also it looks like someone had a go with Travis CI which would be a great idea for testing new Django & python versions... I haven't seen the build status check thing for PRs though. Does anyone have expertise in Travis CI?

[panosl]

I'll try to set up travis-ci but all the tests are currently broken, I merged some of @racitup pull requests, but we need to test things further to push out a version on PyPI.

[racitup]

Thanks for merging everything. I need to get back to this because I've been neglecting stuff. I should also really look at adding tests for the various currency source integrations. I assume the tests.py is compatible with Travis?

[einarf]

The version in master is now 0.4.0, but releases (https://github.com/panosl/django-currencies/releases) claims this version was released May 17, 2016. Can you clean that up to cause less confusion?

Either add releases consistently or just remove them all. 😄 (I ended up building from the 0.4.0 tag and got really confused)

[panosl]

Thanks for merging everything. I need to get back to this because I've been neglecting stuff. I should also really look at adding tests for the various currency source integrations. I assume the tests.py is compatible with Travis?

@racitup as I mentioned earlier, the tests are currently broken, I've set up a travis-ci but we need to fix these first.

@einarf Yup we'll bump the version number soon. The functionality is there, if we clean thing up we might be reaching 1.0 soon.

I have some time now since I'm in between projects, so it'll be great if we can put things together so we can push out a new release out there. All help is welcome!

[racitup]

Is there a description for what 1.0 should be?

[panosl]

Is there a description for what 1.0 should be?

@racitup We have more than enough functionality as it is right now. The thing that we're missing most is testing. Other than that we don't need to work on any added features for now.

After that we can push 0.9 out see if we get any bug reports and finalize the 1.0.

[racitup]

So it seems the tests fail because they can't find the test_data fixture. Since it makes sense for the tests and fixtures to stay together, should we move the tests package to the example project?

[panosl]

@racitup Not really. I was thinking we could drop the example project. The project and documentation are pretty clear, and we don’t need the maintainace overhead. Tests, should be able to be run from without the example project.

[racitup]

I've made a pull request with tests now passing with django >= 1.8 It seems the jsonfield used for the info field does not support older versions of django. Do we need to support these?

error: Django 1.4.22 is installed but Django>=1.8.0 is required by set(['jsonfield'])

[panosl]

Awesome work! No, if people need to use older versions of Django, they can stick to an older currencies version as well.

[racitup]

Cool, I'll add in the build status () and remove django 1.4.22 then. Then I want to implement a load of tests for the management commands (especially yahoo which has ceased). Then I'll fix yahoo somehow (deprecation warning & possibly disable) Then I might even implement an ECB currency source Then I think we'll be ready to roll!

[panosl]

That’s great mate, i appreciate your efforts so much ! Ping me if you need anything.

Στάλθηκε από το iPhone μου

14 Νοε 2018, 3:14 μμ, ο χρήστης «racitup notifications@github.com» έγραψε:

Cool, I'll add in the build status () and remove django 1.4.22 then. Then I want to implement a load of tests for the management commands (especially yahoo which has ceased). Then I'll fix yahoo somehow (deprecation warning & possibly disable) Then I might even implement an ECB currency source Then I think we'll be ready to roll!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[panosl]

We're proud to show () ladies and gentlemen!

[racitup]

Do you have an openexchangerates API key for testing? The one in the README works for currencies but not the rates

[racitup]

Please merge in #66 when you get a chance. Should be ready to roll now. Would be interesting to get codecov going too. I've added it to the dependencies. Then I have another branch ready to merge after that one with version 0.9.0 on it 😊

[panosl]

Awesome work @racitup ! You brought the heat again <3

I've given you write access to the repo, so if I'm not responding, you have authority to do your amazing thing :)

[racitup]

Thanks @panosl,

67 Now integrates all the changes I think we needed. I didn't add ecb in the end, but we do now have codecov integration which I think is much more important!

The last things to do I think are:

• sign up for codecov.io which should get the badge working (edit: badge now works!)
• update the docs
• remove the example if you feel like it. I don't think anything is used there now and it's looking quite dated
• remove south migrations (integrated into django v1.7) and landscape.yaml?

[panosl]

Yup, sounds like a plan. I think we can just call this 1.0. It's been production ready for years now, this is much more with the cleanup and functionality you added :)

[panosl]

Ok, I removed the south migrations and the dated example.

[racitup]

Sweet! Looks much cleaner and we hit 90% coverage :)

[panosl]

Yay! Let's get this thing out there and see if we can set a plan for the next major milestone :D

[racitup]

How about we tag and release this as 0.9.0 and leave it a week or two to see if there are any issues? There's a small tweak that's been bugging me which is to move the currency file caching into the parent CurrencyHandler class which will make it functional for oxr, and I can simplify the tests a bit too... once that's done we can call it 1.0

[panosl]

Alright, I'll tag it and upload on PyPI etc.

[panosl]

@racitup Done, it's public both on GitHub and PyPI. Had a minor glitch with the classifiers, but it's all good!

Thanks for making this a fantastic release! Take your time and we'll talk soon about what we might need to address for 1.0.0

[racitup]

Mmm, I think just remove that classifier.. looks like the Travis build is failing because of it (which is weird)

[panosl]

Nah, it was just travis-ci being stuck. All is good now: https://travis-ci.org/panosl/django-currencies

It was trying to download the pypy3 version but it wasn't available for some reason. Nothing on our end.

[einarf]

Awesome work getting a new release out. You even created a whl and addad 0.9 tag. I'm guessing a lot of people can delete their own forks now. 👍

[racitup]

Thanks Einar. It would be great if you (and others) could use it and let us know if you run into any problems. On 16 Dec 2018 10:58, "Einar Forselv" notifications@github.com wrote:

Awesome work getting a new release out. You even created a whl and addad 0.9 tag. I'm guessing a lot of people can delete their own forks now. 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/panosl/django-currencies/issues/54#issuecomment-447633942, or mute the thread https://github.com/notifications/unsubscribe-auth/ARUOi-mGj1qT3ynr0k8ckxXrHCg-jzo9ks5u5idZgaJpZM4MHMME .