search

panosz / ode_integrators

Examples of ode solvers
0 stars 0 forks source link

Do not hardcode closing orbit tollerance #4

Closed panosz closed 5 years ago

panosz commented 5 years ago

Issue #2, although seemingly fixed revealed that it is not a good idea to hard code the parameters of the strategy that decides whether or not the orbit has closed. We have to pass it as a user options.

For starters, perhaps a parameter tolerance_coefficient, with default value ==1000
so that closing_orbit_tolerance = tolerance_coeff * ode_coeff will do the work for us.

panosz commented 5 years ago

Fixed by commit 43684a1eca4e66a4c4493f70b44acda1b4fdd3d0