panpiort8 / ReactionFeasibilityModel

4 stars 0 forks source link

questions of RFM prediction results #1

Open FoxLouis1 opened 1 month ago

FoxLouis1 commented 1 month ago

I'd like to express my gratitude for your outstanding work 'RetroGFN'. It has been incredibly helpful in my research.This is the prediction results for the example in the notebook using your checkpoint. We notice that the output contains negative values, which contradicts the convention that RFM(x) ∈ [0, 1] in the paper of RetroGFN.Besides, I didn't observe any normalization to [0, 1] in the MLP layer of model. Could you please explain how you constructed the labels and trained the model, and provide the corresponding code? b17fb9e7aa69d2498f7c6b55551cb01

panpiort8 commented 1 month ago

Hello! Thanks for your interest in our work! The model outputs logits $\in \mathbb{R}$ instead of probabilities $\in [0, 1]$, because it was trained with BCEWithLogitsLoss. To obtain the probabilities, one needs to call torch.sigmoid explicitly. In RetroGFN code it's done here.

I've created a PR #2 that adds the training scripts, configs and data preparation pipeline as suggested. I also added a brief description of the dataset preparation in update README.

The training was done as binary classification with label $= 1$ meaning a positive reaction coming from the original USPTO-50k and label $= 0$ being a negative reaction constructed with our data preparation pipeline.

If you need some more clarifications, you're welcome to ask!

FoxLouis1 commented 1 month ago

Thank you very much!