Closed maddovr closed 5 years ago
Hi @maddovr I'll look at these issues in upcoming weekend. Probably you're right and some of the config related issues don't work, I'll fix it! ;-)
If there is no post with a coverImage, GraphQL throws out an error, if there is even one post with a coverImage, it works flawlessly;
Huh, interesting 🤔
I modified
SEO.js
file in order for it to have the lang-meta-keywords attribute, but it doesn't seem to work (it's not recognized in the final build);
I thought this should work out of the box... Sorry, I'll check it.
Lack of blog features (tags, categories, search and comments)?
Yes, I know... These features will be in next major release 👌
Another two suggestions that comes to mind that should be fairly easy to do:
@maddovr
- If there is no post with a coverImage, GraphQL throws out an error, if there is even one post with a coverImage, it works flawlessly;
Do you know how to fix it? 😱 I can't figure it out... 😭 Should I create a custom field with default value in gatsby-node?
I'll think about it when I return home, I'll also review the PR I made with your suggested changes in a few days time (I'm currently abroad). Should be simple with just tweaking the GraphQL queries, but I need to look at it first. Two more issues I should mention:
Thanks for catching these issues. I fixed most of them 👍
Great work porting this theme to gatsby, I've encountered a few issues so maybe you could help me.
gatsby-config.js
, but dark is still the default;<a>
tag ingatsby-config.js
for the footer, you have to manually edit thelayout.js
file;gatsby-config.js
, the title won't appear anymore;SEO.js
file in order for it to have the lang-meta-keywords attribute, but it doesn't seem to work (it's not recognized in the final build);<!-- more-->
, is there a reason to do so in the front matter?There are many things in the list I'm aware, but I think your theme has a very minimal yet elegant design, but unfortunately as I'm busy with my university exams, I'll not be able to help till next month at least. Thank you for your great work anyway.