panr / gatsby-starter-hello-friend

Pretty basic starter for Gatsby that covers all of the essentials. All you have to do is start typing!
MIT License
165 stars 71 forks source link

Maybe a few issues? #1

Closed maddovr closed 5 years ago

maddovr commented 5 years ago

Great work porting this theme to gatsby, I've encountered a few issues so maybe you could help me.

There are many things in the list I'm aware, but I think your theme has a very minimal yet elegant design, but unfortunately as I'm busy with my university exams, I'll not be able to help till next month at least. Thank you for your great work anyway.

panr commented 5 years ago

Hi @maddovr I'll look at these issues in upcoming weekend. Probably you're right and some of the config related issues don't work, I'll fix it! ;-)

If there is no post with a coverImage, GraphQL throws out an error, if there is even one post with a coverImage, it works flawlessly;

Huh, interesting 🤔

I modified SEO.js file in order for it to have the lang-meta-keywords attribute, but it doesn't seem to work (it's not recognized in the final build);

I thought this should work out of the box... Sorry, I'll check it.

Lack of blog features (tags, categories, search and comments)?

Yes, I know... These features will be in next major release 👌

maddovr commented 5 years ago

Another two suggestions that comes to mind that should be fairly easy to do:

panr commented 5 years ago

@maddovr

  • If there is no post with a coverImage, GraphQL throws out an error, if there is even one post with a coverImage, it works flawlessly;

Do you know how to fix it? 😱 I can't figure it out... 😭 Should I create a custom field with default value in gatsby-node?

maddovr commented 5 years ago

I'll think about it when I return home, I'll also review the PR I made with your suggested changes in a few days time (I'm currently abroad). Should be simple with just tweaking the GraphQL queries, but I need to look at it first. Two more issues I should mention:

panr commented 5 years ago

Thanks for catching these issues. I fixed most of them 👍