panrafal / depthy

Extract depth map and original from photos made with Google Camera's Lens Blur.
http://depthy.stamina.pl
MIT License
1.32k stars 164 forks source link

Error in _common.css #17

Closed essembeh closed 10 years ago

essembeh commented 10 years ago

I'm trying to dockerize your app to easily test it without installing all the dependencies.

I have a strange error while running grunt serve

        Warning:  Use --force to continue.

        Aborted due to warnings.

When i fun it with --force, I can browse the server, but I get a CSS error:

Syntax error: Invalid US-ASCII  character "xE2"
 line 326 of /depthy/app/styles/_common.scss

I tried to remove the value of the content = '....' on line 326 and it seems to work.

As I don't understand CSS at all I won't send you a push request ;)

panrafal commented 10 years ago

Probably because all files are UTF-8 encoded, not US-ASCII. This character is unbreakable space and should stay there

essembeh commented 10 years ago

Ok so the problem doesn't come from the css, but I cannot start the grunt server as described in the README.

Any idea how to launch grunt serve without error?

panrafal commented 10 years ago

Can you post the whole console output you see?

essembeh commented 10 years ago
root@12cab9528ed3:/depthy# grunt serve
grunt serve
Running "serve" task

Running "clean:server" (clean) task

Running "concurrent:server" (concurrent) task

    Running "svgmin:dist" (svgmin) task
    ✔ app/images/logo.svg (saved 674 B 30%)
    Total saved: 674 B

    Done, without errors.

    Execution Time (2014-07-04 15:25:13 UTC)
    loading tasks    6ms  ▇▇▇ 5%
    svgmin:dist    105ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 94%
    Total 112ms
        Warning:  Use --force to continue.

        Aborted due to warnings.

Execution Time (2014-07-04 15:25:11 UTC)
concurrent:server  3.9s  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 100%
Total 3.9s

root@12cab9528ed3:/depthy#

As I am working on making a docker image of depthy, if you know docker you can run:

docker run --rm -t -i --entrypoint bash essembeh/depthy

then you can run

grunt serve
essembeh commented 10 years ago

You said that the char in CSS file was an UTF8 char, so I googled and found that by default ubuntu docker images are not utf8 :) http://jaredmarkell.com/docker-and-locales/

I fixed my Dockerfile to have its locale set to en_US.UTF-8 and it works fine.

So you can consider this issue closed, it was not a depthy problem ;)

panrafal commented 10 years ago

Good to know :) On Jul 8, 2014 7:01 PM, "Sébastien M-B" notifications@github.com wrote:

You said that the char in CSS file was an UTF8 char, so I googled and found that by default ubuntu docker images are not utf8 :) http://jaredmarkell.com/docker-and-locales/

I fixed my Dockerfile to have its locale set to en_US.UTF-8 and it works fine.

So you can consider this issue closed, it was not a depthy problem ;)

— Reply to this email directly or view it on GitHub https://github.com/panrafal/depthy/issues/17#issuecomment-48368508.