pantheon-deprecated / terminus-deprecated

Deprecated CLI for Pantheon. Do not install. Current project:
https://github.com/pantheon-systems/cli
82 stars 24 forks source link

psite-clone runs update.php, even without the --update option #156

Open jessepinho opened 10 years ago

jessepinho commented 10 years ago

Pretty much all in the title. Since --update is an option for psite-clone, I would expect it not to run update.php when that option is absent. But it does anyway (according to the "Active Jobs" in the Pantheon dashboard).

joshkoenig commented 10 years ago

I'm not seeing this in my environment. The jobs run are:

Clone Database from Live to Testing
finished a few seconds ago

Copy Files from Live to Testing
finished a few seconds ago
joshkoenig commented 10 years ago

I can confirm that it also doesn't run the db updates upon re-syncing the data.

Can you verify this again on your end, and also try running it with the --debug --verbose flags and gisting the output so we can see?

jessepinho commented 10 years ago

Will do.

First, the screenshot of the dashboard: http://i.imgur.com/G288JTx.png

Re: the gist: are there any security concerns with including Pantheon site and user IDs in the output, or should I remove them first?

joshkoenig commented 10 years ago

You shouldn't have any concerns with exposing UUIDs in public. They don't let anyone do anything without access to your account.

jessepinho commented 10 years ago

Great: https://gist.github.com/jessepinho/802af82f87f1361039a7

joshkoenig commented 10 years ago

So you gist shows that it is indeed setting up update.php to run:

 "params": {"updatedb": 1}

However, this doesn't happen for me when I run it. The only difference I can see is that you're using backticks to fill in the UUID. Can you try it with the uuid in the command rather than in backticks just to eliminate this as a potential problem?

jessepinho commented 10 years ago

https://gist.github.com/jessepinho/802af82f87f1361039a7#file-psite-clone-with-uuid

Even with the raw UUID, it still includes "updatedb": 1. (Just checked the Pantheon dashboard, too, and it did indeed run update.php in testing.)

joshkoenig commented 10 years ago

Crazy! I'll look deeper this weekend. On Jul 18, 2014 8:19 PM, "jessepinho" notifications@github.com wrote:

https://gist.github.com/jessepinho/802af82f87f1361039a7#file-psite-clone-with-uuid

Even with the raw UUID, it still includes "updatedb": 1. (Just checked the Pantheon dashboard, too, and it did indeed run update.php in testing.)

— Reply to this email directly or view it on GitHub https://github.com/pantheon-systems/terminus/issues/156#issuecomment-49495558 .