search

pantheon-systems / autotag

Git repository version tagging tool
http://godoc.org/github.com/pantheon-systems/autotag
Apache License 2.0
192 stars 43 forks source link

use debian-slim instead of alpine as base image #28

Closed ghoussard closed 4 years ago

ghoussard commented 4 years ago

Golang binary is compiled within CircleCI Debian based image (https://hub.docker.com/r/circleci/golang). Go binaries compiled within Debian cannot be executed within Alpine. So, it must be run into Debian based image.

References #26

joemiller commented 4 years ago

I suspect this issue is due to the current release pipeline building a dynamic binary and the linkage between musl in alpine and glibc in debian is the issue. But the current version of autotag uses the git cli instead of C libgit so we should be able to build a static binary. Looking into this now.

joemiller commented 4 years ago

@ghoussard I pushed a temporary image based on #29 if you are interested in a quick test. I did my own quick test and I think this will resolve the issue. The binary should be runnable in the alpine-based container or copyable out of the container and used in any other container so long as git is in $PATH

$ docker run --rm -it -v$PWD:/src -w /src quay.io/pantheon-public/autotag:pr-29  
1.1.5
ghoussard commented 4 years ago

@joemiller It works. Great jobs!

joemiller commented 4 years ago

@ghoussard Great. Sorry about that. docker images quay.io/pantheon-public/autotag:v1.1.5 and :latest should be working now

ghoussard commented 4 years ago

@joemiller Fine. Thanks!