search

pantheon-systems / docker-build-tools-ci

Dockerfile source for docker image pantheon-public/build-tools-ci on quay.io
34 stars 39 forks source link

Add 8.1 to the build_only matrix. #105

Closed kporras07 closed 1 year ago

kporras07 commented 1 year ago

Some extensions were added to the base image and xdebug was removed so I added it back here.

greg-1-anderson commented 1 year ago

The CircleCI cimg/php documentation shows -node and -browsers variants, but not both together. Do we use both node and browsers for built-in features? e.g. could we drop -node and require folks to use a different image for compiling CSS et. al.? It seems more convenient to have -browsers, for JS testing et.al, as part of the base image, if we only get one.

kporras07 commented 1 year ago

Great link thanks!

Looks like browsers supersedes node so that should be enough.

Are you ok changing base image for all 8.x images? (it is 7.4, 8.0 and 8.1 as of now)