Create a version of the Build Tools utilizing PHP 7.4.

pantheon-systems / docker-build-tools-ci

Dockerfile source for docker image pantheon-public/build-tools-ci on quay.io

34 stars 39 forks source link

Create a version of the Build Tools utilizing PHP 7.4. #77

Closed stovak closed 2 years ago

stovak commented 3 years ago

Implementation of Pantheon Internal CMS-21.

stovak commented 3 years ago

requirements:

Integration with quay so it builds new images automatically
Composer 2
pcov module for PHP unit test coverage data without xdebug
GitHub Actions CI template in the repo for people to add to their drupal installs (not sure how those templates work)

stovak commented 3 years ago

Here are my changes... use what you care to: https://github.com/stovak/docker-build-tools-ci

kporras07 commented 3 years ago

Hi @stovak I started working on this. WIP at https://github.com/pantheon-systems/docker-build-tools-ci/compare/6.x...kporras07:7.4.x?expand=1

Questions: 1) Should I create a new branch or PR against 6.x branch? If new, what name? 2) Quay.io: should I setup automatic build for all branches? This could be done directly in quay.io. I think I have the access level needed for this.

Please let me know how to continue with this :)

stovak commented 3 years ago

Yes create two new branches based on 6.x's latest commit, php 7.4 and 8.
only set up CI on the new branches for the moment. If we need to backport we will.

kporras07 commented 2 years ago

Pushed as 7.x-php7.4