search

pantheon-systems / pantheon_domain_masking

Domain Masking helper module for D8
GNU General Public License v2.0
11 stars 6 forks source link

Compatibility with Drupal 9 #11

Open abutler3 opened 3 years ago

abutler3 commented 3 years ago

Our site is upgrading to Drupal 9 and got this in our drupal-check report:

Line pantheon_domain_masking.module 

     Internal error: Call to a member function yes() on bool       
     Run PHPStan with --debug option and post the stack trace to:  
     https://github.com/phpstan/phpstan/issues/new

Line src/Form/DomainMaskingConfigForm.php 

     Internal error: Call to a member function yes() on bool       
     Run PHPStan with --debug option and post the stack trace to:  
     https://github.com/phpstan/phpstan/issues/new

Line src/Helper.php 

     Internal error: Call to a member function yes() on bool       
     Run PHPStan with --debug option and post the stack trace to:  
     https://github.com/phpstan/phpstan/issues/new

Line src/Middleware/DomainMaskingMiddleware.php 

     Internal error: Call to a member function yes() on bool       
     Run PHPStan with --debug option and post the stack trace to:  
     https://github.com/phpstan/phpstan/issues/new

[ERROR] Found 4 errors

davereid-pfg commented 3 years ago

Those don't look like errors that correspond to the module code at all, in fact they're "Internal errors" with phpstan.

jrearick-pfg commented 3 years ago

The only issue Upgrade Status module gave me is a test class not found. It otherwise seems to work.


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Pantheon Domain Masking
Scanned on Thu, 08/05/2021 - 16:44.

1 warning found.

modules/contrib/pantheon_domain_masking/src/Form/DomainMaskingConfigForm.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │ 13   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘