pantheon-systems / pantheon_domain_masking

Domain Masking helper module for D8
GNU General Public License v2.0
11 stars 6 forks source link

BUG at URL append using strpos #7

Open eabquina opened 3 years ago

eabquina commented 3 years ago

Background:

For Country-based masked sites, India will sometimes be configured as "in" on the module. In the function section where we append the subpath to the request URL, we use strpos to accomplish the conditional lookup.

In the case of "SCRIPT_NAME" and "SCRIPT_FILENAME", these usually default to /index.php thus causing the issue to incorrectly match the lookup.

davereid-pfg commented 3 years ago

Looks like this can be closed now that https://github.com/pantheon-systems/pantheon_domain_masking/pull/8 is merged.