pantheon-systems / pantheon_domain_masking

Domain Masking helper module for D8
GNU General Public License v2.0
11 stars 6 forks source link

Please publish this to Drupal.org? #9

Open davereid-pfg opened 3 years ago

davereid-pfg commented 3 years ago

I don't want to have to recommend people add a new repository line to their composer.json for all of our projects using our install profile. Can we please make this module available at https://www.drupal.org/project/pantheon_domain_masking like you do already with https://www.drupal.org/project/pantheon_advanced_page_cache? It would go a long way to make this more easily available, since it seems like a feature that most sites on Pantheon will want to use.

jrearick-pfg commented 3 years ago

I thought this would be available using composer require pantheon-systems/pantheon_domain_masking like composer require pantheon-systems/terminus works, but it doesn't.

I think it would work to have it out on packagist. However Dave is right, being a Drupal module, it would make sense to mirror it on drupal.org.

stevector commented 3 years ago

Thanks for the suggestion @davereid-pfg! I'll put this issue on the agenda for the next meeting of our internal open source group. I don't have much familiarity with this module but I've done the publishing of Pantheon Advanced Page Cache and it's easy enough to sync between GitHub and Drupal.org.

ctlopez-PFG commented 3 years ago

@stevector when will the next meeting of your internal open source group be? Just asking as your latest comment was back in March.

jrearick-pfg commented 2 years ago

Bump. Just adding this to another project and still not finding it on d.o or packagist.

kyletaylored commented 2 years ago

@markely @joebortelpantheon Do you think this is something we can make happen? I know @stovak did the same thing with updating the Pantheon Search API module.

kyletaylored commented 2 years ago

@jrearick-pfg This should now be live on Packagist: https://packagist.org/packages/pantheon-systems/pantheon_domain_masking

namespacebrian commented 2 years ago

Note that the change in package name/installation instructions broke composer builds for sites currently using this module.

jrearick-pfg commented 2 years ago

I noticed that existing sites using it, but build process broke. Here's how I fixed it for us:

When trying to do a composer update I got the following error:

# composer update
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies                                
Your requirements could not be resolved to an installable set of packages.

Problem 1
    - Root composer.json requires drupal/pantheon_domain_masking dev-master, found drupal/pantheon_domain_masking[dev-master] in the lock file but not in remote repositories, make sure you avoid updating this package to keep the one from the lock file.

The fix

In your project's composer.json remove the pantheon part from the repositories section and the drupal/pantheon_domain_masking line from your require section. Save those changes and run composer require pantheon-systems/pantheon_domain_masking to re-add the dependency from Packagist. The diff in your composer.json should look something like this:

Screen Shot 2022-02-18 at 2 39 23 PM-redacted

namespacebrian commented 2 years ago

wrong ticket x(