search

pantheon-systems / quicksilver-examples

Example scripts for using Pantheon's Quicksilver Platform Hooks
https://docs.pantheon.io/guides/quicksilver
MIT License
128 stars 114 forks source link

Set Apdex T values on multidev creation #89

Closed stevector closed 7 years ago

stevector commented 8 years ago

Fulfills https://github.com/pantheon-systems/quicksilver-examples/issues/86

stevector commented 8 years ago

I'm assigning to @ataylorme since he is working on a revision that will copy the T values from the Dev environment.

ataylorme commented 8 years ago

@stevector added you as an assignee for review.

stevector commented 8 years ago

@ataylorme Can you review again. I made a bug fix commit here: https://github.com/pantheon-systems/quicksilver-examples/pull/89/commits/2dcaad02828ced796f4bd8f44439d9c091ce06f9

I was testing by setting the dev environment to a custom value like 0.44 and seeing if that carried over to new environments. Before this latest commit the set_thresholds() call to get_nr_connection_info() was returning the stats for the current environment (the new multidev).

ataylorme commented 8 years ago

@stevector this looks good to me - nice work catching that bug.

stevector commented 8 years ago

@ataylorme I'm taking us off the assignee field since we've both written and tested the code. Can someone else review/merge?

ataylorme commented 8 years ago

@ari-gold can you help with review/testing?

ari-gold commented 8 years ago

@ataylorme @stevector Yes, will do. Thanks for the ping.

ataylorme commented 7 years ago

@ari-gold bump again - would love to get this one merged in

ari-gold commented 7 years ago

Tested and LGTM!

$ terminus workflows watch --site=ari
<snip>
[2016-10-07 20:14:37] [info] 
------ Operation: Set Apdex T values finished in 5s (apdex-test) ------
===== Setting New Relic Values for the App 'ari_7 (apdex-test)' =====
Application Apdex Threshold: 0.5
End User Apdex Threshold: 7
Enable Real User Monitoring: 1
===== Finished Setting New Relic Values =====

New settings show up in New Relic UI: image