pantheon-systems / quicksilver-pushback

Push any commits made on the Pantheon dashboard back to the original GitHub repository.
MIT License
14 stars 13 forks source link

BUGS-3487 OSD not getting pushed back to canonical repository due to malformed git commit author #18

Closed marfillaster closed 2 years ago

marfillaster commented 3 years ago

This fixes the missing email causing git commit to fail. Somehow escapeshellarg is stripping the email part.

Manual testing

git checkout -b qs-pushback-test
composer config repositories.qs vcs https://github.com/marfillaster/quicksilver-pushback
composer config minimum-stability dev

Edit composer.json

-  "pantheon-systems/quicksilver-pushback": "^2",
+  "pantheon-systems/quicksilver-pushback": "dev-authorfix as 2.0.1",

Update composer and commit composer.json and composer.lock

composer update
git add composer.json composer.lock
git commit
greg-1-anderson commented 2 years ago

This was fixed in another commit some time ago.