search

pantheon-systems / solr-power

A WordPress plugin to connect to Pantheon's Apache Solr search infrastructure, or your own!
https://wordpress.org/plugins/solr-power/
GNU General Public License v2.0
126 stars 61 forks source link

Recent update to Solarium 4 is not compatible with Solr < 6 #380

Closed mgburns closed 6 years ago

mgburns commented 6 years ago

See https://github.com/solariumphp/solarium/blob/master/CHANGELOG.md#removed-2.

As far as I know the current version of Solr on Pantheon is 3.6 so this is a problem.

danielbachhuber commented 6 years ago

@mgburns Huh. Any ideas why our tests still pass then?

danielbachhuber commented 6 years ago

cc @ataylorme

mgburns commented 6 years ago

I'm not sure. I had thought it was breaking the default query operator setting, but that turned out to be a red herring as I had some code in my local instance attempting to address issues I raised in https://github.com/pantheon-systems/solr-power/issues/371#issuecomment-420260848 that was causing it.

So I can't point to anything specific that it breaks, but that line in the changelog is still disconcerting.

ataylorme commented 6 years ago

I did not find any incompatibilities in my testing either. If you run into anything @mgburns please let us know.

ataylorme commented 6 years ago

BC break: Suggester component is now compatible to Solr v6/7 (the existing one was renamed to Spellcheck) BC break: Suggester query type is now compatible to Solr v6/7 (the existing one was renamed to Spellcheck)

Those are the changes I saw in the changelog and they relate to the Suggester component, which Solr Power does not make use of.

danielbachhuber commented 6 years ago

@ataylorme I think we're still fine to release 2.0.0. I'm out of the office tomorrow through the 25th though, so I'd prefer to do the release after that point in case there's any cleanup.

@mgburns Are you able to use the 2.0.0 release candidate against your current project to see if you run into any issues with operation?

mgburns commented 6 years ago

Unfortunately this particular site is launching today with the previous release of this plugin. We have some other projects that are earlier in development that could potentially switch -- I'll get back to you.

ataylorme commented 6 years ago

I think we're still fine to release 2.0.0.

That's good because it went out on Monday 9/10. The automated tests passed and I tested on the cars site with 40k items indexed and didn't run into any issues.

danielbachhuber commented 6 years ago

That's good because it went out on Monday 9/10.

@ataylorme Ah. Can you make sure to create a tag? https://github.com/pantheon-systems/solr-power/releases

ataylorme commented 6 years ago

I created one but forgot to push it. It is there now

danielbachhuber commented 6 years ago

Closing — haven't seen any fallout from this so assuming the breaks didn't impact us.