pantheon-systems / terminus-composer-plugin

A Terminus plugin for running Composer commands on a Pantheon site
MIT License
15 stars 9 forks source link

"Could not apply patch! Skipping." #7

Open dalin- opened 4 years ago

dalin- commented 4 years ago

Running commands that apply patches locally works just fine. But not via the terminus composer plugin

Package operations: 1 install, 0 updates, 0 removals
  - Installing drupal/core (8.7.14): Downloading (100%)
  - Applying patches for drupal/core
    https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch (2869592 - Disabled update module shouldn't produce a status report warning)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch
    https://www.drupal.org/files/issues/2019-03-05/2815221-116.patch (2815221 - Add quickedit to the latest-revision route)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-03-05/2815221-116.patch
    https://www.drupal.org/files/issues/2018-10-12/1356276-531.patch (1356276 - Allow profiles to define a base/parent profile and load them in the correct order)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2018-10-12/1356276-531.patch
    https://www.drupal.org/files/issues/2018-07-09/2914389-8-do-not-test.patch (2914389 - Allow profiles to exclude dependencies of their parent)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2018-07-09/2914389-8-do-not-test.patch

If I crank up the verbosity -vvv then in this section I get

  - Applying patches for drupal/core
    https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch (2869592 - Disabled update module shouldn't produce a status report warning)
Downloading https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch
patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac59b2a7.patch'
Executing command (CWD): patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac59b2a7.patch'
sh: patch: command not found

patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac59b2a7.patch'
Executing command (CWD): patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac59b2a7.patch'
sh: patch: command not found

patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac59b2a7.patch'
Executing command (CWD): patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac59b2a7.patch'
sh: patch: command not found

patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac59b2a7.patch'
Executing command (CWD): patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac59b2a7.patch'
sh: patch: command not found

   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch
    https://www.drupal.org/files/issues/2019-03-05/2815221-116.patch (2815221 - Add quickedit to the latest-revision route)
Downloading https://www.drupal.org/files/issues/2019-03-05/2815221-116.patch
patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5ca3c3.patch'
Executing command (CWD): patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5ca3c3.patch'
sh: patch: command not found

patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5ca3c3.patch'
Executing command (CWD): patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5ca3c3.patch'
sh: patch: command not found

patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5ca3c3.patch'
sh: patch: command not found

patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5ca3c3.patch'
Executing command (CWD): patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5ca3c3.patch'
Executing command (CWD): patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5ca3c3.patch'
sh: patch: command not found

   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-03-05/2815221-116.patch
    https://www.drupal.org/files/issues/2018-10-12/1356276-531.patch (1356276 - Allow profiles to define a base/parent profile and load them in the correct order)
Downloading https://www.drupal.org/files/issues/2018-10-12/1356276-531.patch
patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5f1252.patch'
Executing command (CWD): patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5f1252.patch'
sh: patch: command not found

patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5f1252.patch'
Executing command (CWD): patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5f1252.patch'
sh: patch: command not found

patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5f1252.patch'
Executing command (CWD): patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5f1252.patch'
sh: patch: command not found

patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5f1252.patch'
Executing command (CWD): patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac5f1252.patch'
sh: patch: command not found

   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2018-10-12/1356276-531.patch
    https://www.drupal.org/files/issues/2018-07-09/2914389-8-do-not-test.patch (2914389 - Allow profiles to exclude dependencies of their parent)
Downloading https://www.drupal.org/files/issues/2018-07-09/2914389-8-do-not-test.patch
patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac629719.patch'
Executing command (CWD): patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac629719.patch'
sh: patch: command not found

patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac629719.patch'
Executing command (CWD): patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac629719.patch'
sh: patch: command not found

patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac629719.patch'
Executing command (CWD): patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac629719.patch'
sh: patch: command not found

patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac629719.patch'
Executing command (CWD): patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5ec69ac629719.patch'
sh: patch: command not found

   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2018-07-09/2914389-8-do-not-test.patch

Looks like the servers do not have patch installed.

To get an idea of the scope of this bug, 95% of our Drupal 8 sites are using composer-patches.

en-cc-org commented 4 years ago

Hello - Same error for me, using cweagans/composer-patches, via terminus, with a different core patch. Note that my module patches applied ok - but wondering if they worked via git apply, while the core patch needed 'patch', and terminus could not access patch? Thanks

Applying patches for drupal/core using terminus composer update https://www.drupal.org/files/issues/2020-05-30/cannot-use-relationship-2457999-236.patch (Issue #2457999: Cannot use relationship for rendered entity on Views) Downloading https://www.drupal.org/files/issues/2020-05-30/cannot-use-relationship-2457999-236.patch patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5f762804df4f7.patch' Executing command (CWD): patch '-p1' --no-backup-if-mismatch -d 'web/core' < '/tmp/5f762804df4f7.patch' sh: patch: command not found

patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5f762804df4f7.patch' Executing command (CWD): patch '-p0' --no-backup-if-mismatch -d 'web/core' < '/tmp/5f762804df4f7.patch' sh: patch: command not found

patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5f762804df4f7.patch' Executing command (CWD): patch '-p2' --no-backup-if-mismatch -d 'web/core' < '/tmp/5f762804df4f7.patch' sh: patch: command not found

patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5f762804df4f7.patch' Executing command (CWD): patch '-p4' --no-backup-if-mismatch -d 'web/core' < '/tmp/5f762804df4f7.patch' sh: patch: command not found

Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-05-30/cannot-use-relationship-2457999-236.patch