pantheon-systems / terminus-rsync-plugin

Terminus Plugin that provides a quick shortcut for rsync-ing files to and from a Pantheon site.
MIT License
18 stars 10 forks source link

Clarity around rsyncOptions flags and defaults #14

Open salvamomo opened 4 years ago

salvamomo commented 4 years ago

Hello! I've a question around default usage of the plugin. I've recently worked with the plugin and there's something that took me by surprise on the default args it's using:

-rlIpz --temp-dir=~/tmp --delay-updates are used when the are no rsyncConfig args provided via terminus.

In particular, the -I (uppercase i) is what caught me. According to rsync manual:

-I, --ignore-times don't skip files that match size and time.

So basically, that's making my rsync calls push everything onto the server whenever I run it (this is done in CI jobs), which is undesired because in my use case this can be several GBs of data, with a small subset likely to change.

I figured terminus rsync $source $dest -- -az gets the job done, and it's the way I've always used rsync.

Is there a reason for this? Is there anything I should be aware of when not using the default flags? The concern is that for being defaults, having -I seemed strange, so I'm wondering what's the reason behind it and if I should be aware of any implications for not using it.

Thank you!

deviantintegral commented 4 years ago

I noticed https://github.com/pantheon-systems/terminus-rsync-plugin/pull/13 too.