search

pantheon-systems / terminus-site-clone-plugin

A Terminus plugin that adds the `site:clone` command to facilitate cloning sites on Pantheon
MIT License
21 stars 12 forks source link

Update to Terminus 2 #16

Closed greg-1-anderson closed 5 years ago

ataylorme commented 5 years ago

I'll need to either test manually, write some tests, or both

greg-1-anderson commented 5 years ago

The functional tests in the terminus-plugin-example use BATS to test using simple shell scripts. BATS probably isn't even necessary - just running a script withset -e would also be pretty simple and effective.

ataylorme commented 5 years ago

@greg-1-anderson what do you think about doing a 2.0.0 version of terminus-site-clone with Terminus 2 support and deprecating the current 1.0.0 release?

greg-1-anderson commented 5 years ago

@ataylorme The site clone plugin is mostly going to be used on the end-user's development machine. Most users should upgrade to Terminus 2 pretty quickly; I don't think that ongoing support for Terminus 1 is critical.

For Build Tools, I left the 1.x branch compatible with Terminus 1 (only), and I made the 2.x / master branch compatible with Terminus 2 (only). This is certainly the easiest thing for plugins that make any API calls that vary from one major version of Terminus to the next.

vinmassaro commented 5 years ago

Subscribing to this issue and can do testing of any PRs since we used this plugin often with Terminus 1.x. Thanks!

ataylorme commented 5 years ago

@vinmassaro can you test the update I just pushed?

vinmassaro commented 5 years ago

@ataylorme :100: Was able to successfully clone a D7 site on the first try. The site files were also around ~1.13GB and I did not encounter any issues as I would have expected based on the docs warning about the 500MB limit.

ataylorme commented 5 years ago

@vinmassaro glad the Terminus 2 version in this PR is working for you! I am going to leave this open for a bit to allow for more testing and feedback before merging and tagging a new release.