PHP error when running command with source site that did not previously have a files backup

[stevector]

I was a on a call today with a custom upstreams user. We tried making a new site and cloning db/code/files from an old site. On the first attempt the code and db cloned successfully. Files cloning died with this error:

Fatal error: Call to a member function serialize() on null in /Users/anne/.terminus/plugins/terminus-site-clone-plugin/src/Commands/SiteCloneCommand.php on line 258

We ran the command again and it completed successfully.

Just reading through the relevant section of code, I think I see the problem. I've added inline comments here:

        $backups = $site['env_raw']->getBackups()->getFinishedBackups($element);
        // $backups might be empty.
        // But the variable is not updated inside this conditional.
        if ( empty($backups) ) {
            $this->log()->notice(
                "No {element} backups in the {site}.{env} environment found.\n",
                [
                    'site' => $site['name'],
                    'env' => $site['env'],
                    'element' => $element,
                ]
            );
            $this->createBackup($site);
        }
        // So $backups could still be empty here.
        $latest_backup = array_shift($backups);
        // and then $latest_backup is null.
        $return = $latest_backup->serialize();

@ataylorme, am I missing any context? I think the fix could be a small PR.

[ataylorme]

@stevector I think you are correct that we just need to add $backups = $site['env_raw']->getBackups()->getFinishedBackups($element); after $this->createBackup($site); in the if ( empty($backups) ) conditional.

[ataylorme]

@stevector can you review #3?