search

pantheon-systems / terminus

The Pantheon CLI — a standalone utility for performing operations on the Pantheon Platform
https://pantheon.io
Other
318 stars 195 forks source link

LOPS-2222 fix spurious test issue WIP #2573

Closed stovak closed 7 months ago

stovak commented 7 months ago

Running two or more terminus test cycles creates a resource contention with the fixture sites. This is an attempt to create the fixture sites on the fly before the testing cycle starts.

guardrails[bot] commented 7 months ago

:warning: We detected 1 security issue in this pull request:

Insecure File Management (1)
Severity | Details | Docs :-: | :-- | :-: Medium | Title: **FileSystem function with user input**
https://github.com/pantheon-systems/terminus/blob/4548aa8320757b4240e6420f0628b22879c7559a/scripts/RunTestsCommand.php#L134 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/php/Insecure_file_management.html?utm_source=ghpr#PHPCS_SecurityAudit.BadFunctions.FilesystemFunctions.ErrFilesystem) More info on how to fix Insecure File Management in [PHP](https://docs.guardrails.io/docs/en/vulnerabilities/php/Insecure_file_management.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

greg-1-anderson commented 7 months ago

This seems like too much. Why not just run terminus site:create in the CI configuration scripts? The bespoke fixture management code in PHP feels too heavy to maintain when we could just have a few lines of script in the configuration. Also, the tests have been like this for a long time; is this really the time to fix this? An 8-point story that didn't go through PBR is over the usual allowance for engineering excellence work. I think that we should get back to regular sprint work now.