search

pantheon-systems / wp-native-php-sessions

Implement native PHP sessions stored in the database for WordPress.
https://wordpress.org/plugins/wp-native-php-sessions/
GNU General Public License v2.0
138 stars 43 forks source link

Session callback must have a return value of type bool, null returned #257

Open olegabr opened 1 year ago

olegabr commented 1 year ago

https://github.com/pantheon-systems/wp-native-php-sessions/blob/a1fa5e03808fdef0f393569d409cf55f1bbc1dc4/inc/class-session-handler.php#L89

Just return false here?

rwagner00 commented 1 year ago

Thanks for the report. As a quick clarification, what is the calling code that produces the error?

olegabr commented 1 year ago

It is better to return true there actually, or an error would be reported.

I do not have any specific calling code for this. It is just called normally from WordPress internals.

paulpullen commented 9 months ago

I just ran into this during a site upgrade to PHP 8.2. Any chance the fix could be merged into the next plugin update?