pantheon-systems / wp-redis

WordPress Object Cache using Redis.
https://wordpress.org/plugins/wp-redis/
GNU General Public License v2.0
226 stars 68 forks source link

Version 1.1.0 of WP Redis causes the page list on sites running WordPress 5.5 to timeout #291

Closed lukecav closed 4 years ago

lukecav commented 4 years ago

The fix was to roll back to version 1.0.1 of WP Redis using WP-CLI.

wp plugin update wp-redis --version=1.0.1

The page list in wp-admin would timeout and would not load with WP Redis version 1.1.0 active on the site. Not sure if the issue is being caused by? https://github.com/pantheon-systems/wp-redis/pull/287

danielbachhuber commented 4 years ago

Thanks for the report, @lukecav.

I'm not able to recreate the problem. Could you share more details about the site (plugins, amount of data), or steps I can follow to reproduce?

lukecav commented 4 years ago

wp plugin list --status=active +-------------------------------------+--------+-----------+---------+ | name | status | update | version | +-------------------------------------+--------+-----------+---------+ | advanced-custom-fields-pro | active | none | 5.8.14 | | autoptimize | active | none | 2.7.6 | | cache-enabler | active | none | 1.3.5 | | custom-post-type-ui | active | none | 1.8.0 | | ml-slider | active | none | 3.17.0 | | ninja-forms | active | none | 3.4.25 | | post-types-order | active | none | 1.9.5.1 | | stackable-ultimate-gutenberg-blocks | active | none | 2.9.1 | | the-events-calendar | active | none | 5.1.5 | | unique-headers | active | none | 1.7.12 | | widget-options | active | none | 3.7.4 | | wp-redis | active | available | 1.0.1 | | wp-youtube-lyte | active | none | 1.7.13 | | wordpress-seo-premium | active | none | 13.3 | +-------------------------------------+--------+-----------+---------+

danielbachhuber commented 4 years ago

Hi @lukecav,

This isn't quite enough information to go on. I'll need enough information to reproduce the issue, or you'll need to do a bit of debugging to identify the root cause.

lukecav commented 4 years ago

None of the other active plugins were causing the issue on the page list not loading in wp-admin. Posts and postmeta data levels were not even that high on the site. The same issue happened on another site as well.

lukecav commented 4 years ago

wp_posts 53.5MB wp_postmeta 111.6MB

danielbachhuber commented 4 years ago

None of the other active plugins were causing the issue on the page list not loading in wp-admin.

Did you try leaving WP Redis active, deactivating all other plugins, and then activating each plugin one by one to see which introduced the slowness?

lukecav commented 4 years ago

Yep, I did and none of the plugins being activated one by one resolved the issue for the page list in wp-admin not loading.

danielbachhuber commented 4 years ago

Ok.

  1. When you say "Pages list", what part of the UI are you referring to?
  2. Can you enable WP_DEBUG and let me know of any errors you see?
lukecav commented 4 years ago
  1. Pages > All Pages /wp-admin/edit.php?post_type=page
  2. Yep will do.
lukecav commented 4 years ago

Waiting to be able to enable the WP Redis plugin again and enable debugging on the customer's site to get the info.

stavultras commented 4 years ago

Please try to use 1.1.1 version, there were some fixes (today, after your last comment) about multiple keys caching, not sure if they fix your problem, but i think it's worth to try.

lukecav commented 4 years ago

@stavultras Version 1.1.1 version fixed the issue on the site.

stavultras commented 4 years ago

@lukecav good to know, thanks :)

danielbachhuber commented 4 years ago

@stavultras Double props to you — thanks again!