search

pantheon-systems / wp-redis

WordPress Object Cache using Redis.
https://wordpress.org/plugins/wp-redis/
GNU General Public License v2.0
226 stars 68 forks source link

Use in_array in wp_cache_supports #380

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

From #378

CdrMarks commented 1 year ago

Hi Viktor, thanks for the PR. We copied the function added in #378 from WordPress core.

Is there a performance benefit possible with this change?

szepeviktor commented 1 year ago

@CdrMarks All right. I'm not willing to push my agenda. Has Daniel gone away?

BTW all code ending in return true/false shows a developer not understanding booleans

szepeviktor commented 1 year ago

I'm sorry. I am used to "Thank you, Viktor" + merge.

CdrMarks commented 1 year ago

Has Daniel gone away?

Correct; he's no longer working on Pantheon's plugins.

I'm going to close this for now. Do let us know if you see any other issues.

szepeviktor commented 1 year ago

@CdrMarks 6 years of contribution has to stop. It is very sad.

CdrMarks commented 1 year ago

It is very sad.

@ szepeviktor Yes it’s sad Daniel’s gone, but Pantheon now has a team dedicated to maintaining these plugins.