search

pantheon-systems / wp-redis

WordPress Object Cache using Redis.
https://wordpress.org/plugins/wp-redis/
GNU General Public License v2.0
225 stars 67 forks source link

[CMSP-353] Add pantheon-wp-coding-standards #400

Closed jazzsequence closed 1 year ago

jazzsequence commented 1 year ago

Adds our coding standards and fixes sniffs.

Also updates the circle lint workflow to use PHP 8

pwtyler commented 1 year ago

Interesting to note that behat fell down where phpunit did not. Is that a case we should cover with unit testing?

jazzsequence commented 1 year ago

Interesting to note that behat fell down where phpunit did not. Is that a case we should cover with unit testing?

@pwtyler I think there are legit issues that were introduced by some of the fixes for PHPCS sniffs. I'm trying to put stuff back the way it was to see if it can get through Behat and then be more intentional about what I'm changing. But I do think that if things are failing, probably unit tests should cover those unless they are legitimately not able to be covered by functional tests.

jazzsequence commented 1 year ago

Nevermind, it's the upstream tests that are failing, not the Behat tests running from the plugin. 🤦

pwtyler commented 1 year ago

Will hold review until #406 is updated with same behat fixes and this PR is rebased.

jazzsequence commented 1 year ago

@pwtyler This PR removes the upstream behat tests (although they're still loaded as a repository, we just aren't running them). I think while https://github.com/pantheon-systems/pantheon-wordpress-upstream-tests/pull/62 is still WIP we can go ahead and merge this and move forward and re-add the upstream tests as those are fixed.

(actually those were removed in @jspellman814's update)