search

pantheon-systems / wp-redis

WordPress Object Cache using Redis.
https://wordpress.org/plugins/wp-redis/
GNU General Public License v2.0
225 stars 67 forks source link

[CMSP-459] Updates behat tests and behaviors. #430

Closed rwagner00 closed 1 year ago

rwagner00 commented 1 year ago

Ports behat fixes from https://github.com/pantheon-systems/wp-redis/pull/429/files into its own PR.

This PR also removes the terminus redis:enable step in bin/behat-prepare.sh. There's no reason to ever disable redis on the fixture running Behat tests, and the enable step spawns many duplicate "redis enable" requests, most of which time-out, causing the tests to fail.

Tests can be seen as passing (with #437) here: https://app.circleci.com/pipelines/github/pantheon-systems/wp-redis/1629/workflows/fd714abf-075f-45f8-9102-3ddc730f731e/jobs/4980

pwtyler commented 1 year ago

Are some of these tests specific to #426 and therefore now failing on this branch?

jazzsequence commented 1 year ago

it's possible the base branch of this PR should be update-object-cache

pwtyler commented 1 year ago

There were both test regressions (tests needed to be fixed) and legitimate errors (code needed to be fixed) @rwagner00 addressed in getting #426 green. Anything that fixes default's failing tests should be split out to this PR, anything else should remain and be fixed up in 426 after this is merged. I'm not sure if the legitimate errors are errors introduced in 426, or in one of our recent merges to default though.