Closed geoffg-sentry closed 2 months ago
The original Github.Repo.HookModified rule is inappropriately named and had some errors in its tests. The hook.* audit log events capture any webhook event that occurs in a repository, organization, GitHub Marketplace account, GitHub Sponsors account, or GitHub App. The rule initially was designed to capture any webhook modification but labelled and titled as repo-specific.
Github.Repo.HookModified
hook.*
This corrects the minor error with an appropriately named rule, fixes the tests, and improves the alert title. The core logic remains the same.
GitHub.Webhook.Modified
pat test, make lint
Background
The original
Github.Repo.HookModifiedrule is inappropriately named and had some errors in its tests. Thehook.*audit log events capture any webhook event that occurs in a repository, organization, GitHub Marketplace account, GitHub Sponsors account, or GitHub App. The rule initially was designed to capture any webhook modification but labelled and titled as repo-specific.This corrects the minor error with an appropriately named rule, fixes the tests, and improves the alert title. The core logic remains the same.
Changes
GitHub.Webhook.Modified, add to packsTesting
pat test, make lint