panther-labs / panther-analysis

Built-in Panther detection rules and policies
https://panther.com/
Apache License 2.0
339 stars 173 forks source link

Update Pack Manifests with Data Models and Globals #1342

Closed ben-githubs closed 2 months ago

ben-githubs commented 2 months ago

Background

Some of the detections used in packs are generic (i.e. they can be used for other log types, and the use data models to do so). In such cases, the unit tests will fail if the data models for those log types aren't present. Additionally, some packs were missing global helpers (either because a new rule was added, or because the top-level helper was included in the pack, but it's dependencies weren't.)

For CI/CD users, these changes are moot, since they always upload the full repo, but for Console users, this can lead to missing dependencies when enabling packs.

For more information, see this ticket in #ask.

Changes

Testing

github-actions[bot] commented 2 months ago

:scream: looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml