panther-labs / panther-analysis

Built-in Panther detection rules and policies
https://panther.com/
Apache License 2.0
339 stars 173 forks source link

Remove Multi-Table Queries from Packs #1353

Closed ben-githubs closed 2 months ago

ben-githubs commented 2 months ago

Background

Some of the queries recently added to packs involve more than one table, which may result in the pack failing to update if the customer has not ingested the corresponding log types yet.

Typically, each pack contains items focusing a single log type (or family of log types). When a customer creates a log source for those log types and ingests data, the data lake tables for those log types are also created. In some queries (namely the "Unauthorized Crowdstrike Device" queries), 2 tables are referenced: a crowdstrike table, and whichever log table the pack utilizes. If the customer hasn't previously ingested crowdstrike logs, the crowdstrike table won't exist, and the query will fail to compile (leading to the pack failing to update).

The same issue can happen if we move these queries to the Crowdstrike pack - the other tables may or may not exist. For the time being, we'll remove these queries from any packs until we can determine the best way to package them.

For more context, review this Slack thread.

Changes

Removed any Crowdstrike Unregistered Device queries (and their rules) from any packs. The items still exist in the repo itself.

Testing

github-actions[bot] commented 2 months ago

:scream: looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml
ben-githubs commented 2 months ago

I thought I wanted feedback on: this might disable the detections for any customers who already have the rule through their pack, and added the query manually. I don't expect there to be many (if any) customers who have done this, but worth calling out. The more conservative approach would be to just remove the queries and leave the rules in - the rules will simple never execute if the query isn't present, and if it is, they will operate normally.

Thoughts?