pantherale0 / ha-nintendoparentalcontrols

Home Assistant integration for Nintendo Switch Parental Controls
MIT License
80 stars 7 forks source link

Add option to disable alarms for current day #17

Closed mithomas closed 10 months ago

mithomas commented 11 months ago

Checklist

Is your feature request related to a problem? Please describe.

Nintendo's parental control app has a button to disable alarms for the current day - this one is notably absent from the integration.

Describe the solution you'd like

I'd like a new switch which controls the "Disable alarms for the current day" functionality.

I suspect that this might be a setting in the parental_control_settings dict, but I have yet to see the actual JSON for such a communication so II honestly don't know. I did not yet invest the time to reverse-engineer the API in this regard; if you do that structure, I'd be happy to implement this myself and raise a PR. (If you don't I might too at some point, it just will take longer :-).)

Describe alternatives you've considered

n/a

Additional context

Thanks for the effort you put in here so far - great work!

pantherale0 commented 11 months ago

Nice idea, I'll take a look today or tomorrow 👍

pantherale0 commented 10 months ago

Ok, so the functionality for performing the action is already in the pynintendoparental module, just couldn't figure out where the state actually exists in the API itself hence why it was never quite completed. Just bumped the version on the module though as I've now figured out that the current state doesn't actually come from the parental control settings, but instead comes from the device properties itself.

Should be fairly simple to implement a switch now after the changes made in #15. There are a couple of other fixes coming in #16 but I'll get a switch added after I've finished the reauth flows

pantherale0 commented 10 months ago

will be implemented in 0.1.4

mithomas commented 10 months ago

Works great in 0.1.4b0 - many thanks!