search

pantherb / setBfree

DSP tonewheel organ
http://setbfree.org
GNU General Public License v2.0
194 stars 35 forks source link

Vibrato switches MIDI CC values are linked #51

Closed brunetton closed 6 years ago

brunetton commented 6 years ago

Hi again. Still trying to get a full MIDI feedback with command line version, I came across some little things that you maybe would to be aware of. Here is one of those things:

Contrary to all percussion switches that all send 0 or 127 values, the two vibrato buttons sent values are "linked": the value sent by one depends of the actual value of the other:

Vibrato lower Vibrato upper CC value
off on -> off 0
off off -> on 64
on on -> off 32
on off -> on 96
on -> off off 0
off -> on off 32
on -> off on 64
off -> on on 96

Is there any reason for that ?

Expected values:

Vibrato lower Vibrato upper CC value
off on -> off 0
off off -> on 127
on on -> off 0
on off -> on 127
on -> off off 0
off -> on off 127
on -> off on 0
off -> on on 127

Thanks

x42 commented 6 years ago

I'll have a look later, but some of those are intentional. You can use a knob rather than on/off switch to control both at the same time.

Leslie is another one that has a tristate and another combined control with 2^3 values (horn/woofer ^ chorale/off/tremolo)..

What MIDI-CC config are you using?

brunetton commented 6 years ago

Thanks (again) for your answer !

some of those are intentional. You can use a knob rather than on/off switch to control both at the same time.

Ok, I get the point. But is this very coherent with percussion switches ? Personally I'm very happy with percussion switches as I can represent them by 4 buttons in my Open Scene Control instance.

Leslie is another one that has a tristate and another combined control with 2^3 values (horn/woofer ^ chorale/off/tremolo)..

I didn't noticed it but ... but I couldn't have noticed it anyway because I don't get any Leslie feedback ;) A priori, the choice of "multiplexing" values in one message makes things difficult for "decoding" those states back to 2 values for 2 different widget on controller side ! (But in my case, I planned to program custom widgets so I can manage, but this could be a problem for other people).

For a visual idea, here is my current O-S-C configuration for Leslie widget: a 3 state button Osc config screenshot (for now I'm only using upper keyboard)

What MIDI-CC config are you using?

I'm not sure to understand, but here's my configuration file

Thanks !

x42 commented 6 years ago

This should be fixed now -- along with #52. Please test.

brunetton commented 6 years ago

This issue can be closed as I answered on #52