Chorus/vibrato LV2 plugin doesn't launch

[trebmuh]

Disclaimer: reading at this, I do understand that this might not be a priority for this project.

Building setBfree on a Stretch with INSTALL_EXTRA_LV2=yes, the chorus/vibrato LV2 plugin doesn't launch. Starting it in a CLI gives me:

$ jalv.gtk http://gareus.org/oss/lv2/b_chorato
Plugin:       http://gareus.org/oss/lv2/b_chorato
UI:           None
JACK Name:    setBfree Chorus/Vibrato
Sample rate:  48000 Hz
Block length: 256 frames
MIDI buffers: 32768 bytes
Comm buffers: 524288 bytes
Update rate:  25,0 Hz
lilv_lib_open(): error: Failed to open library /usr/lib/lv2/b_chorato/b_chorato.so (/usr/lib/lv2/b_chorato/b_chorato.so: undefined symbol: _Z17getVibratoRoutingP9b_tonegen)
Failed to instantiate plugin.

[x42]

Since it's a missing C++ symbol you also seem to have added ENABLE_CONVOLUTION=yes which forces the compiler to g++. I highly recommend to disable it (default is off).

If you have not set this option, please include a complete compile-log.

PS. The intention to split off the vibrato/chorus was mainly for the purpose of development, to allow to investigate issues without the synth itself.

[trebmuh]

Since it's a missing C++ symbol you also seem to have added ENABLE_CONVOLUTION=yes which forces the compiler to g++. I highly recommend to disable it (default is off).

Thanks for the info @x42 . This flag is used here, originating from the debian packaging.

Would you recommend Debian not to use it as well?

[x42]

Yes, the cabinet emulation was never correct and should not be used.

I guess I should probably remove it, so that it is not inadvertently enabled by packagers.

[trebmuh]

Rebuilding it without ENABLE_CONVOLUTION=yes does make it works. Thanks.

I've committed the change in the debian repo.

[x42]

Merci beaucoup.

[x42]

I've just tagged v0.8.8, that may help to push a new version with the changes.