Closed falkTX closed 4 years ago
Here is a patch fix:
--- setbfree-0.8.11.orig/b_conv/convolution.cc
+++ setbfree-0.8.11/b_conv/convolution.cc
@@ -28,8 +28,8 @@
#include <sndfile.h>
#include <zita-convolver.h>
-#if ZITA_CONVOLVER_MAJOR_VERSION != 3
-#error "This programs requires zita-convolver 3.x.x"
+#if ZITA_CONVOLVER_MAJOR_VERSION != 3 && ZITA_CONVOLVER_MAJOR_VERSION != 4
+#error "This programs requires zita-convolver 3.x.x or 4.x.x"
#endif
#ifndef DFLT_IR_FILE
@@ -182,7 +182,9 @@ initConvolution (
convproc = new Convproc;
convproc->set_options (options);
+#if ZITA_CONVOLVER_MAJOR_VERSION == 3
convproc->set_density (dens);
+#endif
if (convproc->configure (
/*in*/ channels,
@@ -191,6 +193,9 @@ initConvolution (
/*fragm*/ buffersize,
/*min-part*/ buffersize,
/*max-part*/ buffersize /*Convproc::MAXPART*/
+#if ZITA_CONVOLVER_MAJOR_VERSION == 4
+ , dens /*density*/
+#endif
)) {
fprintf (stderr, "\nConvolution: Cannot initialize convolution engine.\n");
exit (1);
Do not compile setBfree with ENABLE_CONVOLUTION
.
The build-in convolver was a failed experiment, has never been enabled by default, and should not be used as-is.
Oh, I was not aware of this at all.. can we make the code error out if enabled then?
can we make the code error out if enabled then?
It's potentially useful for some future dev so that'd be tricky. Then again it hasn't been since 8 years so I might just remove it.
I imagine this is a problem in a few distributions. Debian probably already patched it. EDIT: just checked, debian does not patch anything