search

pantherman594 / BungeeEssentials

Full customization of a few necessary features for your server!
http://www.spigotmc.org/resources/bungeeessentials.1488/
GNU General Public License v3.0
6 stars 8 forks source link

Bug Report - /r nor working properly #34

Closed voigtman closed 8 years ago

voigtman commented 8 years ago

Steps to replicate: player 1 sends message player 2 types '/r some message' and the message does not return to player 1.

BungeeEssentials Version: 2.5.6

Bungee Version: 1156 Minecraft Version: Spigot 1.8.8 Description:

pantherman594 commented 8 years ago

In version 2.5.0 I added a 3-second delay before messages are recorded for replies. Could this be the issue? (Try waiting a little longer before using /r)

voigtman commented 8 years ago

no, players are not able to reply to the original sender unless both use /msg first. Also, I toggled the message recently (just to see what that did) and this has been the case since

pantherman594 commented 8 years ago

Turning messaging off prevents you from getting messaged (unless by an admin). Which error, if any, does it throw when you try to use /r?

voigtman commented 8 years ago

If you've just logged in, and someone messaged you, and you type /r you will get "Nobody has messaged you recently." you have to use /msg to reply to the incoming message. however, if the scenario involves 3 players and player 3 messages one of the other 2, /r only continues the communication between the first 2 players. again, to initiate the reply you must first /msg player3

pantherman594 commented 8 years ago

Is messaging enabled for both?

voigtman commented 8 years ago

messaging is enabled, I thought that was a server-wide command....

pantherman594 commented 8 years ago

No, it's per-player. If you don't want anybody to message you, you turn messaging off for yourself. Is messaging enabled for both players (especially the recipient)?

voigtman commented 8 years ago

yes it's on

pantherman594 commented 8 years ago

Try turning messaging off for the recipient (I might have made a mistake in the code), send the message, and then turn it back on again to reply.

voigtman commented 8 years ago

ok i'll test that... but how do I do that for another player?

pantherman594 commented 8 years ago

Either tell them to do /msg off or you do it and have the other player message you, and you reply.

voigtman commented 8 years ago

so that permits them to reply again.. but only for that one time. if they message another person and player 3 sends a message /r doesn't go back to player 3

pantherman594 commented 8 years ago

I'll try to fix that right now and send you a version to test, and see if it fixes that other problem too.

voigtman commented 8 years ago

ok, cool thank you

pantherman594 commented 8 years ago

Try this: http://ci.pantherman594.com/job/BungeeEssentials/99/artifact/target/BungeeEssentials.jar

voigtman commented 8 years ago

Testing now

voigtman commented 8 years ago

that seems to have fixed it