search

pantoniou / libfyaml

Fully feature complete YAML parser and emitter, supporting the latest YAML spec and passing the full YAML testsuite.
MIT License
241 stars 74 forks source link

Fix CMake scripts & add comments getter API #42

Closed jlblancoc closed 2 years ago

jlblancoc commented 2 years ago

Description:

The comments API has been thoroughly tested in a derived project where a C++ wrapper to this great C library is defined. Furthermore, this wrapper is used as a building block of another project (repo, docs) with its own unit tests. All pass with the code in this PR.

If merged, it would be great to have another release (when time permits! @pantoniou ) since I intend to then package this library into Debian, so it could be easily installed into any Debian/Ubuntu future distro ;-)

pantoniou commented 2 years ago

Interesting. Can I get two separate PRs, one for the cmake changes and a second one of the comment getter API.

I am curious if you had an issues with the comment extraction; there are a few issues that made me make the api internal.

jlblancoc commented 2 years ago

Sure. Closing this PR.

I am curious if you had an issues with the comment extraction; there are a few issues that made me make the api internal.

The most important issue I identified so far is that multi-line comments include the "... \n# ..."s in the middle, what is expected since your lib tries to avoid memory allocation, etc. I handled that by manually fixing multiline comments as done here.