search

pantoniou / libfyaml

Fully feature complete YAML parser and emitter, supporting the latest YAML spec and passing the full YAML testsuite.
MIT License
239 stars 73 forks source link

Problem: fy_node_compare_user does not recurse with itself #86

Closed yrashk closed 3 months ago

yrashk commented 1 year ago

Instead, it recurses with fy_node_compare which, in effect, "loses" user settings.

Solution: make it user the user flavour of the function

yrashk commented 10 months ago

Bumping this up as this seems to be a rather important bug (incomplete comparison using user-supplied comparison methods)

yrashk commented 9 months ago

Any chance this can be reviewed, as it fixes a rather important bug for user-supplied comparisons? Thank you!

(Ideally, together with #87)

yrashk commented 7 months ago

Is there any chance for this to get reviewed? It seems to be a pretty critical piece for user-supplied comparison.

pantoniou commented 7 months ago

Will take a look, seems harmless enough

yrashk commented 6 months ago

Bumping this issue up. Any chance for a review? Thanks! Happy New Year :)

yrashk commented 4 months ago

Bumping this issue up as it is fairly critical.

yrashk commented 3 months ago

Thank you!