search

pantor / ruckig

Motion Generation for Robots and Machines. Real-time. Jerk-constrained. Time-optimal.
https://ruckig.com
MIT License
635 stars 155 forks source link

install headers again #178

Closed v4hn closed 5 months ago

v4hn commented 5 months ago

fixup 24ae2d79

Actually install headers and do not redundantly add the include dir to the target.

INCLUDES DESTINATION flags in install(TARGETS define additional paths that are added to the INTERFACE_INCLUDE_DIRECTORIES, they do not install files.

pantor commented 5 months ago

Thanks!

I still sometimes find the CMake installation and packaging stuff a bit confusing - I'm assuming the PUBLIC_HEADER flag is what I actually wanted.

Greetings from Hamburg to Hamburg, Lars

v4hn commented 5 months ago

I'm assuming the PUBLIC_HEADER flag is what I actually wanted.

I guess that would work, but it's another mechanism in parallel to INTERFACE_INCLUDE_DIRECTORIES of the library targets. Imho installing the include folder seems more readable.

Greetings from Hamburg to Hamburg

If you are around anyway, I would be happy to invite you to our lab for a visit and short talk on your work. :partying_face: