search

pantor / ruckig

Motion Generation for Robots and Machines. Real-time. Jerk-constrained. Time-optimal.
https://ruckig.com
MIT License
730 stars 165 forks source link

Update roots.hpp #185

Closed fehimiltek closed 7 months ago

fehimiltek commented 8 months ago

with mingw it can causes some problems with M_PI macro. with cpp20, this pi number can be defined as standard.

pantor commented 8 months ago

Thanks for the PR! However Ruckig should support C++17 onwards, so we unfortunately can't rely on C++20 features right now. Are you able to add a check for C++20 and use this solution conditionally, otherwise I'll have to close this PR.