pantor / ruckig

Motion Generation for Robots and Machines. Real-time. Jerk-constrained. Time-optimal.
https://ruckig.com
MIT License
734 stars 166 forks source link

fixed copy & paste error in Trajectory::is_phase_synchronizable #32

Closed stefanbesler closed 3 years ago

stefanbesler commented 3 years ago

I am thinking about porting your code to TwinCAT; Looking through the code I found this copy & paste error

gavanderhoorn commented 3 years ago

off-topic but:

I am thinking about porting your code to TwinCAT

would there be a chance you'd make that port available OSS? I'd be interested in that.

pantor commented 3 years ago

Hi @stefanbesler, thanks for catching this error! If there is anything you need for porting Ruckig to TwinCAT, I'll be happy to help.

stefanbesler commented 3 years ago

@gavanderhoorn yes, I want to do, after all @pantor open sourced this library as well, would be pretty unfair to do a closed source port :-D , I'll keep you updated. thanks @pantor, the code seems pretty straight forward to port, I love your coding style.

Danielxyz123 commented 3 years ago

@stefanbesler

Does Twincat support c++17 ? Or is it neccessary to change the code to c++ 14? I would like to use ist on a B&R PLC, but there's no support for c++17. So, i think it's a lot of work to get it run...

gavanderhoorn commented 3 years ago

@stefanbesler wrote:

yes, I want to do, after all @pantor open sourced this library as well, would be pretty unfair to do a closed source port :-D

you wouldn't be the first :)

I'll keep you updated.

would you create a repository somewhere? Then I could simply watch it.

stefanbesler commented 3 years ago

@Danielxyz123 I want to port the code to structured text ( iec 61131-3 ) @gavanderhoorn yes sure, let me get some work done before though, it is quite a bit of code

gavanderhoorn commented 3 years ago

@gavanderhoorn yes sure, let me get some work done before though, it is quite a bit of code

empty repositories can be watched as well :)

Could also provide a venue for discussion -- perhaps even alternative approaches to full ports?


Edit: if you're looking for that of course. If not, /ignore.

stefanbesler commented 3 years ago

@gavanderhoorn here we go https://github.com/stefanbesler/ruckig_TC3_port

traversaro commented 3 years ago

Thanks a lot @stefanbesler ! I can't promise anything and I have no idea on how is easy is to maintain iec 61131-3 libraries that target different vendors, but once the TC3 port is there, I would be interested in looking if we can get it to work on CODESYS. fyi @singhbal-baljinder

pantor commented 3 years ago

@Danielxyz123 Regarding compiling Ruckig with C++14, somebody already asked in #28 about the required changes for C++11. If downgrading to C++14 would be really helpful for you, feel free to reach out once again, as it should be quite easy for me to get it running.

pantor commented 3 years ago

@Danielxyz123 There is now a script to patch Ruckig for C++11.

Danielxyz123 commented 3 years ago

Wow thats great! Thanks a lot 👍.