search

pantor / ruckig

Motion Generation for Robots and Machines. Real-time. Jerk-constrained. Time-optimal.
https://ruckig.com
MIT License
730 stars 165 forks source link

Issue with cpp11 patch #35

Closed Danielxyz123 closed 3 years ago

Danielxyz123 commented 3 years ago

Visual Studio tells me that

"[[maybe_unused]]" for example in the following line

inline bool check([[maybe_unused]] double tf, double jf, double vMax, double vMin, double aMax, double aMin) {

ist not available for cpp11. Or is it my fault?

pantor commented 3 years ago

All errors should be fixed now, at least using GCC version 5 on Ubuntu 18.04 (as this is tested now in CI). Can you confirm this?

Danielxyz123 commented 3 years ago

Thx a lot. Yes it works in Visual Studio (Win), but only without compiler WX flag...

There are warnings like:

Warnung C4127 Bedingter Ausdruck ist konstant

For Example in the following Line (line 56 in profile.hpp)

   if (limits == Limits::ACC0) {
pantor commented 3 years ago

Ok, I've now removed the flags for treating warnings as errors for the C++ patch. Unfortunately, I don't have the time to fix the warnings itself.

Danielxyz123 commented 3 years ago

👍

Danielxyz123 commented 3 years ago

Hi Pantor, i only want so give some feedback. It's working on the B&R PLC with the cpp11 patch! It uses the GCC Compiler 6.3.0. The performance seems to be good. Great work 👍