search

pantsbuild / binaries

A temporary home for pants static binaries and scripts
16 stars 37 forks source link

Add build support for thrift 0.13.0, 0.14.2 & 0.15.0. #101

Closed jsirois closed 2 years ago

jsirois commented 2 years ago

These all build clean in the pantsbuild/centos7 docker image and on macOS 11.6.1 (intel) with MACOSX_DEPLOYMENT_TARGET=10.14.

Closes #99

jsirois commented 2 years ago

Are the build-thrift.sh scripts all identical?

Yes. Linux all ==, Mac almost, one extra disable for swift. I definitely noticed this, I definitely did not want to invest any time so just copied both scripts, edited build.sh with new version, moved on.

jsirois commented 2 years ago

Ok, now tested on macOS 11.6.1 10.14.6 and 10.12.6.