pantsbuild / binaries

A temporary home for pants static binaries and scripts
16 stars 37 forks source link

Sierra support #17

Closed michaelgmiller closed 8 years ago

michaelgmiller commented 8 years ago

Hey there!

I foolishly upgraded to macOS Sierra on opening day, and see "FAILURE: Update --binaries-path-by-id to find binaries for Darwin x86_64 16.0.0" when I try to run a pants binary. Can y'all build the 10.12 binaries? Happy to help in any way!

Thanks! Mike

jsirois commented 8 years ago

I can be upgraded by Thursday, 9/22 and so get binaries built by EOW.

michaelgmiller commented 8 years ago

That would be awesome!! Thanks for the quick turnaround!

jsirois commented 8 years ago

Erm, guess not:

about_this_mac

This means I'm finally done with OSX - yay! I hope you can find another taker. I suggest you pop in to pants-devel@googlegroups.com or out slack channel - see here for contact info: http://www.pantsbuild.org/community.html (this repo's issues are not really watched by anyone).

mateor commented 8 years ago

I can do this, I think. I will have to update my personal machine over the weekend, so if there are any takers to do it earlier, please go for it.

michaelgmiller commented 8 years ago

I'm happy to help with this, if someone would be so kind as to guide me through the steps.

On Thu, Sep 22, 2016 at 1:45 PM, Mateo Rodriguez notifications@github.com wrote:

I can do this, I think. I will have to update my personal machine over the weekend, so if there are any takers to do it earlier, please go for it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pantsbuild/binaries/issues/17#issuecomment-248975938, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDISo28nBxjScUjPEAVShcgkVZYPralks5qsr7LgaJpZM4KCNu3 .

kwlzn commented 8 years ago

do we actually need Sierra-specific bins or should this be backwards compatible? couldn't we just link the new OS version key to the previous bins and publish that as an interim solution?

michaelgmiller commented 8 years ago

I'm fine with linking the binaries to the old version :)

On Thu, Sep 22, 2016 at 1:47 PM, Kris Wilson notifications@github.com wrote:

do we actually need Sierra-specific bins or should this be backwards compatible? couldn't we just link the new OS version key to the previous bins and publish that as an interim solution?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pantsbuild/binaries/issues/17#issuecomment-248976417, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDISpBAs5JRS38DQ3PmdEkk2_IwKLXuks5qsr8ygaJpZM4KCNu3 .

mateor commented 8 years ago

That is what we do internally, fwiw. We host a mirror and used symlinks to test Yosemite support.

I think you can test if it works for you through config:

[binaries]
path_by_id:   {
  ('darwin', '16'): ('mac', '10.11')}

Which just maps your version to the old OS. It doesn't look like the fingerprints properly respect that change however, so you may have to delete the old location and clean.

    rm -rf ~/.cache/pants/bin
    ./pants clean-all
    ./pants gen examples/src/thrift::

You could also just try adding symlinks yourself in the .cache/pants directories. But they are per-tool so a little invention/grinding would be required.

mateor commented 8 years ago

I ran behind this weekend but I left my personal box updating to Sierra when I left for the office this morning, with the hope of building when I got home.

mateor commented 8 years ago

Binaries are merged at: https://github.com/pantsbuild/binaries/commit/8628bf48db2f47aa8c1f208e5aacfc506b065654 The Pants binary_util map was updated: https://github.com/pantsbuild/pants/commit/e815eeba2dccaaca904349d75ca4dae1f8ff334e

Pulling to Pants master should be able to consume full Sierra support.

tinder-jhan commented 7 years ago

If you are using pants 1.0.1, should add the following to the pants.ini for Sierra.

[binaries] path_by_id: {('darwin', '16'): ['mac', '10.12']}

Should be [] not () as Mateor mentioned otherwise you will get error like this "Exception message: can only concatenate tuple (not "list") to tuple"

rogen92 commented 7 years ago

Hi,

I added the following in my pants.ini file in my repo

[binaries] path_by_id:{('darwin', '16'):['mac', '10.12']}

but now I'm getting this error while building my project with pants in Intellij. Could someone help me with this??

Error:pants export --formatted --export-libraries-sources --export-libraries-javadocs src/python/myProject/:: --export-output-file=/private/var/folders/j_/wj355bgx7q50ltyh2svv19br5bk4cm/T/pants_depmap_run682.out
Exit code: 1

FAILURE: Failed to fetch binary bin/thrift/mac/10.12/0.9.2/thrift from any source: (Failed to fetch binary from https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/mac/10.12/0.9.2/thrift: Problem GETing data from https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/mac/10.12/0.9.2/thrift: HTTPSConnectionPool(host='akamai.bintray.com', port=443): Read timed out. (read timeout=1.0))


FAILURE

INFO] Attempting to fetch thrift binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/mac/10.12/0.9.2/thrift ...
wisechengyi commented 7 years ago

@rogen92

  1. [binaries]
    path_by_id:{('darwin', '16'):['mac', '10.12']}

    should be no longer necessary.

  2. the issue is failing to fetch https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/mac/10.12/0.9.2/thrift, which is a valid url. maybe you can do ./pants clean-all then try again?

rogen92 commented 7 years ago

@wisechengyi

That didn't work... Getting this error after a pants clean up

Error:pants export --formatted --export-libraries-sources --export-libraries-javadocs src/java/com/myProject/myPath:: --export-output-file=/private/var/folders/j_/wj355bgx7q50ltyh2svv19br5bk4cm/T/pants_depmap_run59.out
Exit code: 1

FAILURE: Update --binaries-path-by-id to find binaries for Darwin x86_64 16.4.0.


FAILURE
rogen92 commented 7 years ago

Got it.... The problem was one of the dependencies mentioned in the pants.BUILD file was wrong for me.

PS: I also cleared cache in .cache/pants