search

pantsbuild / binaries

A temporary home for pants static binaries and scripts
16 stars 37 forks source link

OSX Support for 10.12 #18

Closed mateor closed 8 years ago

mateor commented 8 years ago

Is there a decent way to validate this without syncing to bintray?

I checked a couple of the thrift binaries - everything else, I am just hoping that the scripts are working as intended and that I copied them around without fat-fingering anything.

mateor commented 8 years ago

References #17

mateor commented 8 years ago

Hmmm...this commit list doesn't match my branch order, but instead looks to match the commit timestamp.

It may track better to look at my branch:

https://github.com/mateor/binaries/commits/gh-pages

stuhood commented 8 years ago

Yes: you can validate by adding a file:// URL to your binary baseurls.

On Sep 28, 2016 2:45 PM, "Mateo Rodriguez" notifications@github.com wrote:

Is there a decent way to validate this without syncing to bintray?

I checked a couple of the thrift binaries - everything else, I am just hoping that the scripts are working as intended and that I copied them

around without fat-fingering anything.

You can view, comment on, or merge this pull request online at:

https://github.com/pantsbuild/binaries/pull/18 Commit Summary

  • Add autogen for flex binary and misc thrift 0.9.x script updates.
  • Add OSX 10.12 thrift 0.9.2 binary
  • Add watchman for OSX 10.12
  • Add stack 0.1.6.0 for OSX 10.12.
  • Add ragel 6.9 for OSX 10.12
  • Add protobuf 2.6.1 for OSX 10.12.
  • Add protobuf 2.5.0 for OSX 10.12.
  • Inject a missing include into protobuf 2.4.1 source
  • Add protobuf 2.4.1 for OSX 10.12
  • Add go symlinks for OSX 10.12
  • Add thrift 0.9.1 for OSX 10.12
  • Add thrift 0.9.3 for OSX 10.12.
  • Adjust node build scripts to interpolate mac destination dir.
  • Update Node 6.2.0 for OSX 10.12 support.
  • Add OSX 10.12 support to node 5.5.0.
  • Add support for OSX 10.12 to Node 4.2.4.
  • Add node 4.0.0 for OSX 10.12
  • Add node 0.12.7 for OSX 10.12
  • Add thrift 0.7.0 for OSX 10.12
  • Add thrift-0.5.0-finagle support for OSX 10.12

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pantsbuild/binaries/pull/18, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC2lJdU8NCAG6RqQyXl-ecmQrR1DXMiks5qut_4gaJpZM4KJWc5 .

mateor commented 8 years ago

Update: On my sierra box:

   ./pants gen examples:: contrib::
   ./pants compile examples:: contrib:: src::

succeed with the following patch pointing to my local version of this pull request:

diff --git a/pants.ini b/pants.ini
index 02af268..d5b79a8 100644
--- a/pants.ini
+++ b/pants.ini
@@ -148,6 +148,8 @@ skip: True
 [pycheck-context-manager]
 skip: True

+[binaries]
+baseurls: ['/Users/mateor/development/binaries/build-support']

 [compile.zinc]
 jvm_options: [
diff --git a/src/python/pants/binaries/binary_util.py b/src/python/pants/binaries/binary_util.py
index e600230..2625453 100644
--- a/src/python/pants/binaries/binary_util.py
+++ b/src/python/pants/binaries/binary_util.py
@@ -33,6 +33,7 @@ _DEFAULT_PATH_BY_ID = {
   ('darwin', '13'): ('mac', '10.9'),
   ('darwin', '14'): ('mac', '10.10'),
   ('darwin', '15'): ('mac', '10.11'),
+  ('darwin', '16'): ('mac', '10.12'),
 }

(The compile actually failed the unused dep check, but that isn't pertinent to this PR)

stuhood commented 8 years ago

Good enough for me! Thanks Mateo.