Closed mateor closed 8 years ago
References #17
Hmmm...this commit list doesn't match my branch order, but instead looks to match the commit timestamp.
It may track better to look at my branch:
Yes: you can validate by adding a file://
URL to your binary baseurls.
On Sep 28, 2016 2:45 PM, "Mateo Rodriguez" notifications@github.com wrote:
Is there a decent way to validate this without syncing to bintray?
I checked a couple of the thrift binaries - everything else, I am just hoping that the scripts are working as intended and that I copied them
around without fat-fingering anything.
You can view, comment on, or merge this pull request online at:
https://github.com/pantsbuild/binaries/pull/18 Commit Summary
- Add autogen for flex binary and misc thrift 0.9.x script updates.
- Add OSX 10.12 thrift 0.9.2 binary
- Add watchman for OSX 10.12
- Add stack 0.1.6.0 for OSX 10.12.
- Add ragel 6.9 for OSX 10.12
- Add protobuf 2.6.1 for OSX 10.12.
- Add protobuf 2.5.0 for OSX 10.12.
- Inject a missing include into protobuf 2.4.1 source
- Add protobuf 2.4.1 for OSX 10.12
- Add go symlinks for OSX 10.12
- Add thrift 0.9.1 for OSX 10.12
- Add thrift 0.9.3 for OSX 10.12.
- Adjust node build scripts to interpolate mac destination dir.
- Update Node 6.2.0 for OSX 10.12 support.
- Add OSX 10.12 support to node 5.5.0.
- Add support for OSX 10.12 to Node 4.2.4.
- Add node 4.0.0 for OSX 10.12
- Add node 0.12.7 for OSX 10.12
- Add thrift 0.7.0 for OSX 10.12
- Add thrift-0.5.0-finagle support for OSX 10.12
File Changes
- M README.md https://github.com/pantsbuild/binaries/pull/18/files#diff-0 (6)
- M build-node-4.2.4.sh https://github.com/pantsbuild/binaries/pull/18/files#diff-1 (25)
- M build-node-5.5.0.sh https://github.com/pantsbuild/binaries/pull/18/files#diff-2 (25)
- M build-node-6.2.0.sh https://github.com/pantsbuild/binaries/pull/18/files#diff-3 (31)
- M build-protobuf-2.4.1.sh https://github.com/pantsbuild/binaries/pull/18/files#diff-4 (8)
- A build-support/bin/go/mac/10.12/1.4.2/go.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-5 (1)
- A build-support/bin/go/mac/10.12/1.5.1/go.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-6 (1)
- A build-support/bin/go/mac/10.12/1.5.2/go.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-7 (1)
- A build-support/bin/go/mac/10.12/1.5.3/go.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-8 (1)
- A build-support/bin/go/mac/10.12/1.5/go.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-9 (1)
- A build-support/bin/go/mac/10.12/1.6.1/go.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-10 (1)
- A build-support/bin/go/mac/10.12/1.6.2/go.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-11 (1)
- A build-support/bin/go/mac/10.12/1.6/go.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-12 (1)
- M build-support/bin/node/linux/i386/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-13 (0)
- M build-support/bin/node/linux/i386/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-14 (0)
- M build-support/bin/node/linux/i386/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-15 (0)
- M build-support/bin/node/linux/x86_64/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-16 (0)
- M build-support/bin/node/linux/x86_64/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-17 (0)
- M build-support/bin/node/linux/x86_64/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-18 (0)
- M build-support/bin/node/mac/10.10/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-19 (2)
- M build-support/bin/node/mac/10.10/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-20 (2)
- M build-support/bin/node/mac/10.10/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-21 (2)
- A build-support/bin/node/mac/10.11/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-22 (1)
- D build-support/bin/node/mac/10.11/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-23 (0)
- D build-support/bin/node/mac/10.11/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-24 (0)
- A build-support/bin/node/mac/10.11/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-25 (1)
- A build-support/bin/node/mac/10.11/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-26 (1)
- D build-support/bin/node/mac/10.11/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-27 (0)
- A build-support/bin/node/mac/10.12/v0.12.7/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-28 (0)
- A build-support/bin/node/mac/10.12/v4.0.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-29 (0)
- A build-support/bin/node/mac/10.12/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-30 (0)
- A build-support/bin/node/mac/10.12/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-31 (0)
- A build-support/bin/node/mac/10.12/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-32 (0)
- M build-support/bin/node/mac/10.6/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-33 (2)
- M build-support/bin/node/mac/10.6/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-34 (2)
- M build-support/bin/node/mac/10.6/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-35 (2)
- M build-support/bin/node/mac/10.7/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-36 (2)
- M build-support/bin/node/mac/10.7/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-37 (2)
- M build-support/bin/node/mac/10.7/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-38 (2)
- M build-support/bin/node/mac/10.8/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-39 (2)
- M build-support/bin/node/mac/10.8/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-40 (2)
- M build-support/bin/node/mac/10.8/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-41 (2)
- M build-support/bin/node/mac/10.9/v4.2.4/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-42 (2)
- M build-support/bin/node/mac/10.9/v5.5.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-43 (2)
- M build-support/bin/node/mac/10.9/v6.2.0/node.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-44 (2)
- A build-support/bin/protobuf/mac/10.12/2.4.1/protoc https://github.com/pantsbuild/binaries/pull/18/files#diff-45 (0)
- A build-support/bin/protobuf/mac/10.12/2.5.0/protoc https://github.com/pantsbuild/binaries/pull/18/files#diff-46 (0)
- A build-support/bin/protobuf/mac/10.12/2.6.1/protoc https://github.com/pantsbuild/binaries/pull/18/files#diff-47 (0)
- A build-support/bin/ragel/mac/10.12/6.9/ragel https://github.com/pantsbuild/binaries/pull/18/files#diff-48 (0)
- A build-support/bin/stack/mac/10.12/0.1.6.0/stack.tar.gz https://github.com/pantsbuild/binaries/pull/18/files#diff-49 (0)
- A build-support/bin/thrift/mac/10.12/0.5.0-finagle/thrift https://github.com/pantsbuild/binaries/pull/18/files#diff-50 (0)
- A build-support/bin/thrift/mac/10.12/0.7.0/thrift https://github.com/pantsbuild/binaries/pull/18/files#diff-51 (0)
- A build-support/bin/thrift/mac/10.12/0.9.1/thrift https://github.com/pantsbuild/binaries/pull/18/files#diff-52 (0)
- A build-support/bin/thrift/mac/10.12/0.9.2/thrift https://github.com/pantsbuild/binaries/pull/18/files#diff-53 (0)
- A build-support/bin/thrift/mac/10.12/0.9.3/thrift https://github.com/pantsbuild/binaries/pull/18/files#diff-54 (0)
- A build-support/bin/watchman/mac/10.12/4.5.0/watchman https://github.com/pantsbuild/binaries/pull/18/files#diff-55 (0)
- M build-thrift-0.9.1.sh https://github.com/pantsbuild/binaries/pull/18/files#diff-56 (22)
- M build-thrift-0.9.2.sh https://github.com/pantsbuild/binaries/pull/18/files#diff-57 (26)
- M build-thrift-0.9.3.sh https://github.com/pantsbuild/binaries/pull/18/files#diff-58 (27)
Patch Links:
- https://github.com/pantsbuild/binaries/pull/18.patch
- https://github.com/pantsbuild/binaries/pull/18.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pantsbuild/binaries/pull/18, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC2lJdU8NCAG6RqQyXl-ecmQrR1DXMiks5qut_4gaJpZM4KJWc5 .
Update: On my sierra box:
./pants gen examples:: contrib::
./pants compile examples:: contrib:: src::
succeed with the following patch pointing to my local version of this pull request:
diff --git a/pants.ini b/pants.ini
index 02af268..d5b79a8 100644
--- a/pants.ini
+++ b/pants.ini
@@ -148,6 +148,8 @@ skip: True
[pycheck-context-manager]
skip: True
+[binaries]
+baseurls: ['/Users/mateor/development/binaries/build-support']
[compile.zinc]
jvm_options: [
diff --git a/src/python/pants/binaries/binary_util.py b/src/python/pants/binaries/binary_util.py
index e600230..2625453 100644
--- a/src/python/pants/binaries/binary_util.py
+++ b/src/python/pants/binaries/binary_util.py
@@ -33,6 +33,7 @@ _DEFAULT_PATH_BY_ID = {
('darwin', '13'): ('mac', '10.9'),
('darwin', '14'): ('mac', '10.10'),
('darwin', '15'): ('mac', '10.11'),
+ ('darwin', '16'): ('mac', '10.12'),
}
(The compile actually failed the unused dep check, but that isn't pertinent to this PR)
Good enough for me! Thanks Mateo.
Is there a decent way to validate this without syncing to bintray?
I checked a couple of the thrift binaries - everything else, I am just hoping that the scripts are working as intended and that I copied them around without fat-fingering anything.