search

pantsbuild / binaries

A temporary home for pants static binaries and scripts
16 stars 37 forks source link

add xz package #66

Closed cosmicexplorer closed 6 years ago

cosmicexplorer commented 6 years ago

We are allowing BinaryTools to be downloaded from a specified set of urls (which is an option of the BinaryTool subsystem) in pantsbuild/pants#5780. The LLVM package is available for binary download, but only as an xz file. This means we need to add the ability to extract .tar.xz archives -- that pull request adds an XZ BinaryTool (which we provide in this PR -- it's a ~1MB tar.gz archive), which is then used to decompress BinaryTool subclasses with archive_type='txz' very naturally and efficiently.

I have tested building this and using it with the above PR on my linux and osx laptops, as well as with the pantsbuild/centos6 Docker image, and this is ready for review.

cosmicexplorer commented 6 years ago

pantsbuild/pants#5780 needs some more work before it's mergeable, so while this pr is not likely to change, it doesn't need to be reviewed yet. I will comment again when review is necessary.

stuhood commented 6 years ago

@cosmicexplorer : Are you ready to land this?

cosmicexplorer commented 6 years ago

Yes! On Fri, May 11, 2018 at 10:11 Stu Hood notifications@github.com wrote:

@cosmicexplorer https://github.com/cosmicexplorer : Are you ready to land this?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/pantsbuild/binaries/pull/66#issuecomment-388426554, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPqT8-ynY71P_jFEXBt6z0CKPtooTdYks5txcZUgaJpZM4T447p .

stuhood commented 6 years ago

Merged and synced.