search

pantsbuild / binaries

A temporary home for pants static binaries and scripts
16 stars 37 forks source link

add reproducible scripts for the rust 1.42.0 toolchain #97

Closed cosmicexplorer closed 4 years ago

cosmicexplorer commented 4 years ago

The build-cargo.sh script was derived from the code that currently bootstraps pants, especially bootstrap_rust.sh: https://github.com/pantsbuild/pants/blob/9960d8834a369f6dea1a1b940eb039d90843db37/build-support/bin/native/bootstrap_rust.sh#L26-L31

To upgrade to new rust toolchain versions, we would:

  1. make a PR against this repo
  2. copy/paste build-cargo.sh into the appropriate new versioned subdirectories as specified in this repo's README
  3. then modify build.sh in the new subdirectories to pull down the new rust version instead of 1.42.0.

The pants PR to consume this as part of a rust/cargo backend has not yet been created, so this will not be ready for review until that PR has passed review.

cosmicexplorer commented 4 years ago

I believe this can be closed in favor of invoking rustup in pantsbuild/pants#9781.