search

pantsbuild / intellij-pants-plugin

IntelliJ Plug-in for Pants Build
Apache License 2.0
74 stars 55 forks source link

Reduce number of calls to findPantsRoot #574

Closed tpasternak closed 3 years ago

tpasternak commented 3 years ago
  1. findPantsRoot was called indirectly by JarMappings::librariesFile. This was happening on each VFS event, so could be expensive
  2. librariesFile needs BSP roots path. Previously it was extracted from expensive importsFor method.
  3. Now, the importsFor method is simplified, so it just takes BSP root from getBasePath. This means we don't support cases when two .bloop projects are imported into a single IJ project. Anyways, the support for this was never used or tested.